Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variables for credentials #8

Open
joefearnley opened this issue Nov 17, 2017 · 2 comments
Open

Environment variables for credentials #8

joefearnley opened this issue Nov 17, 2017 · 2 comments

Comments

@joefearnley
Copy link
Contributor

joefearnley commented Nov 17, 2017

Hi @peter279k,

Would you consider add the phpdotenv package as a dependency for handling credentials?

https://github.com/vlucas/phpdotenv

If I can add this I would easily be able to document the examples for SendGrid and Mailjet.

Let me know what you think.

@peter279k
Copy link
Owner

Hi @joefearnley, thank you for your suggestion.
The phpdotenv package I have considered before, but I don't have the experience with that.
It looks great and let the credentials be the environment variables.
Once adding this package, I hope the whole API requiring the credentials should be changed into this way.

Thanks.

@joefearnley
Copy link
Contributor Author

Great @peter279k. I will look into adding this dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants