Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_external_url should have a proper timeout set #286

Open
norbertcyran opened this issue Nov 10, 2022 · 0 comments
Open

load_external_url should have a proper timeout set #286

norbertcyran opened this issue Nov 10, 2022 · 0 comments

Comments

@norbertcyran
Copy link

requests.get which is used by _load_external_url method, by default does not have any timeout set, while it's recommended for nearly all the production code to set some proper value. Currently, it's possible that premailer hangs forever when there are issues with a resource server.

Ref: https://requests.readthedocs.io/en/latest/user/quickstart/#timeouts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant