Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadStream/WriteStream can lead to data races #63

Open
floren opened this issue May 4, 2021 · 0 comments
Open

ReadStream/WriteStream can lead to data races #63

floren opened this issue May 4, 2021 · 0 comments

Comments

@floren
Copy link
Contributor

floren commented May 4, 2021

If someone calls ReadStream, then proceeds to read from it slowly, then someone else calls WriteStream, the reader will start to get the new resource contents part-way through. This is because createKeyFileWithNoLock calls os.OpenFile with O_TRUNC set when updating a file, and the existing reader ends up pointing at the new data.
@floren floren mentioned this issue May 4, 2021
Closed
floren added a commit to floren/diskv that referenced this issue May 4, 2021
@floren
Add test for issue peterbourgon#63
5a1fbbe
floren added a commit to floren/diskv that referenced this issue May 6, 2021
@floren
Add test for issue peterbourgon#63
aa7c583
floren added a commit to floren/diskv that referenced this issue May 6, 2021
@floren
Implement fix for peterbourgon#63, read streams getting invalid data …
ff85ff0 
…after write.

This reworks the createKeyFileWithLock function (used only by
writeStreamWithLock) so it always writes to a temporary file, which
is renamed by writeStreamWithLock when complete. A deferred recover is
added to clean up the temporary file if writing fails. This essentially
deprecates the TempDir option by making all writes atomic.
@floren floren mentioned this issue May 6, 2021
Open
@kwilczynski kwilczynski mentioned this issue Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@floren