Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSTPD is not downsampling the signal when provided with high sampling frequencies #5

Open
LegrandNico opened this issue Sep 22, 2022 · 4 comments

Comments

@LegrandNico
Copy link

LegrandNico commented Sep 22, 2022

If I am reading the code correctly, it looks like the MSTPD algorithm is never downsampling the signal, irrespective of the input sampling frequency, as the variable do_ds is fixed to 0 before being tested see here, this part of the code is apparently never executed.

@LegrandNico
Copy link
Author

Also in line with this problem, if the signal was downsampled, this line here should not operate on rel_sig but on win_sig .

@peterhcharlton
Copy link
Owner

Fantastic - thanks very much for highlighting this. I'll try to correct this shortly.

@wesambachir
Copy link

I have missed peaks (using the provided sample data) for all the beat detectors in the toolbox. Although you pointed out this in your video clip, however I could not find out how to resolve this issue. Could you please explain that.

@LegrandNico
Copy link
Author

On a related note, I have finished the Python implementation of the MSPTD in Systole (see the dev branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants