-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missed peaks #6
Comments
Thanks for your query. Might you be able to provide the process to replicate this issue (e.g. specify which sample data you used, and the code you used)? Please note that in the 'PPG beat detection tutorial', it appears that all the peaks were correctly detected by the 'IMS' beat detection algorithm when using this sample data. Perhaps you have been using one of the other sample data files which do result in missed beats? Many thanks |
Thank you, figure('Position', [20,20,1000,350]) % Setup figure |
Thanks very much indeed for highlighting this. I was mistaken when I said "it appears that all the peaks were correctly detected" - as you highlighted in your PDF, they weren't. I've had a brief look and it appears that the problem is in the definition of a 'local maximum' (and 'local minimum') in the tidy_peaks_and_onsets function within detect_ppg_beats.m. The current definitions assume that these consist of a single sample at either a maximum (or minimum). In the sample data there are instances of local minima consisting of multiple consecutive samples at the same amplitude, which means they are not identified as local minima. I'll work on adjusting this. |
Thank you Dr. Peter for your reply. I'll be looking forward for the corrected code. |
Hi Dr.Peter, I have the same issue, but when I try to use the sample data file "MIMIC_PERform_1_min_normal.mat" on the performance assessment tutorial Could you explain if there is a problem in a function within detect_ppg_beats.m , why access_beat_detectors.m ,which have also use the functions in _detect_ppg_beats.m , will return 100 F1 score in some beat detectors? By the way, I have another question, is it possible to get the heart rate data plot beside a PPG signal(ex. 70beats/min)? I'm not quite understand how these procedures work, I had a brief look on your paper which had mentioned time alignment, it seems that I cannot simply treat every peak in a PPG signal as a correct beat, but there is no tutorial explain how to do time alignment with PPG and ECG on your webpage(https://ppg-beats.readthedocs.io/en/latest/tutorials/time_alignment/), I have tried to read the functions in access_beat_detectors.m but it is way too hard for me to understand. |
Thanks once again @wesambachir . I think I've now resolved this problem with commit df24b4d . |
@MitsurugiMeiya my apologies, I haven't fully understood your question. However:
Does that help? |
I have missed peaks (using the provided sample data) for all the beat detectors in the toolbox. Although you pointed out this in your video clip, however I could not find out how to resolve this issue. Could you please explain that.
The text was updated successfully, but these errors were encountered: