Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store cmprefimpl strings in a separate file #486

Open
peterstace opened this issue Jan 10, 2023 · 0 comments
Open

Store cmprefimpl strings in a separate file #486

peterstace opened this issue Jan 10, 2023 · 0 comments
Labels
improve Improve (or remove) an existing feature

Comments

@peterstace
Copy link
Owner

Currently, the input strings for the cmprefimpl tests are scraped from the simplefeatures codebase. The intention is that the unit tests in the codebase contain a lot of WKT literals, which are perfect inputs for the cmprefimpl tests.

This approach has the downside that the addition of new unit tests can sometimes cause the cmprefimpl tests to fail. Any additional unit tests (with novel inputs) can create additional cmprefimpl test cases, which may fail.

It would be nice if the cmprefimpl inputs were decoupled from the unit tests. One way to do this could be to:

  • Store the inputs to cmprefimpl in a text file (under version control).
  • Create a utility to scrape the codebase to populate the text file. This utility would be run manually.
  • The utility might need blacklisting functionality.
@peterstace peterstace added the improve Improve (or remove) an existing feature label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve Improve (or remove) an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant