Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring #34

Open
decebals opened this issue Apr 6, 2018 · 1 comment
Open

Small refactoring #34

decebals opened this issue Apr 6, 2018 · 1 comment

Comments

@decebals
Copy link
Member

decebals commented Apr 6, 2018

I intend to make a refactoring:

  • move FileDownloader and SimpleFileDownloader in a new downloader package
  • move FileVerifier and VerifierException in verifier package

What you say?

@janhoy
Copy link
Member

janhoy commented Apr 6, 2018

Or leave the interfaces in the main package, but create sub packages for the implementations?

I don't know how likely it is for the framework to ship with other FileDownloaders to warrant a separate package but who knows? Perhaps more likely to get more UpdateRepositories in the future. In my Solr effort I already have a GitHubUpdateRepository and an ApacheUpdateRepository and they both use the SimpleFileDownloader but some custom Verifiers.

But I don't feel strongly about it, I'm ok with packages for everything, we just need to consider releasing one 2.1.0 version with the move but where the current classes are also present but Deprecated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants