[Draft] Add upgrade lock file and healthcheck to the container #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! I'll take a look at this over the next few days. CI seems to be failing atm, but it probably won't be hard to get things working the way we want. 😄 |
|
As a quick eyeball of this (proper review will come later), I wonder if the CI problem is from the execute bit not being set on the new script? |
|
Hmmm, this seems like mismatching file names too: vs: Will probably need to build a container using this PR and check properly. Prob not tonight though. 😉 |
|
good catch, i changed the script name and missed this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #59
dont have time to test it but should work.