Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello from husky-talisman! #8

Open
olmesm opened this issue Nov 3, 2021 · 1 comment
Open

Hello from husky-talisman! #8

olmesm opened this issue Nov 3, 2021 · 1 comment

Comments

@olmesm
Copy link

olmesm commented Nov 3, 2021

Hi Prashant!

I'd love to remove the user split between node-talisman and husky-talisman, but there are a few things that would prevent full adoption of your package from my side or the few of my package's users.

I originally created husky-talisman to fulfil a need for zero-dependency due to client requirements. This is the only challenge I would raise to what you have created - they do have a lot of similarities after all.

Would you have any interest in targeting zero-dependencies for this? Do you have capacity?

@pgmanutd
Copy link
Owner

pgmanutd commented Nov 3, 2021

Hey Oliver,

Long time back I created this package when I was in Thoughtworks. I needed cli support in one of my node projects but didn't find any package online. This package just downloads the latest talisman cli and users can run it as they like. Sure I can make it independent of any package. Right now it uses the following:

  • clogy: This is my library only and it has no dependency on any other package. If you want I can remove this but it has no dependency at all.
  • exec-sh: Can replace this with inbuilt node functionality
  • mkdirp: Can replace this with inbuilt node functionality
  • request: Already deprecated. Can replace this with inbuilt node functionality

I'll try to see if I can pull this one over the weekend or probably next week 😃

Also I need to do some cleanup and replace few deprecated or outdated things with the latest one's but that can be done later also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants