Cannot build for PG16r1

[JamesInform]

I cannot build the compoent for PG16r1.

Are you planning to update the extension any time soon?

[mkgrgis]

@JamesInform , please show the main compilation problems by your opinion. How many problems there are?

[JamesInform]

Hi!

[mkgrgis]

@JamesInform , this is make stop because anybody have never try to compile against PG16r1 ;-) Please add in

sqlite_fdw/Makefile

Line 40 in 90dad0a

ifeq (,$(findstring $(MAJORVERSION), 11 12 13 14 15))

in your clone and ./test.sh How many tests will be failed? Maybe compilation will be impossible?

[mkgrgis]

@JamesInform , you should also copy tests from 15.0 to your version identify directory, see https://github.com/pgspider/sqlite_fdw#tests and my extended draft https://github.com/mkgrgis/sqlite_fdw/tree/readme-fix-and-additions#tests.

[JamesInform]

Thanks. When I run ./test.sh I get:

Building throws an error:

[mkgrgis]

@JamesInform , what was the method of Pg source getting in you case? git? wget ... tar.gz? Something other? Have you tested make check of PostgreSQL sources itself? Please also refer my draft about testing environment https://github.com/mkgrgis/sqlite_fdw/blob/readme-fix-and-additions/TESTING.md

[JamesInform]

Are you able to compile the source against PG16rc1?

[mkgrgis]

@JamesInform , I don't know about pgspider team, but I haven't tried to compile the source against PG16rc1. Anyway this need test file copying and analyse after resolving compilation problems if there are.

[JamesInform]

Maybe you can try to compile.
It seems you are more familiar with testing and error identification than me.

[mkgrgis]

It seems you are more familiar with testing and error identification than me.

I had have no testing experience at all some month before. In C projects usually somebody are welcome for questions and experiments. This is 2 sources of my testing experience. I have no experience to adopt some FDW to a new release.

[t-kataym]

@JamesInform ,
We have been developing to support 16beta2 and will publish it by the end of this month.

[JamesInform]

Great. Thanks for informing!

[devrimgunduz]

@t-kataym v16 is due tomorrow. What is the status of the patch?

Regards, Devrim

[t-kataym]

Almost is done for v16beta2. We are in progress to confirm on v16.0 and will release in the next week.

[t-kataym]

We have just released new sqlite_fdw supporting PostgreSQL16.0.

[devrimgunduz]

Thanks! I can confirm that it builds cleanly.

[mkgrgis]

@devrimgunduz , could you please also give some advices around of #80 ?

[mkgrgis]

@t-kataym I think this is solved and outdated issue after CI.yml using.