Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop DC_P and DC_OAI datastreams #69

Open
giulioturetta opened this issue Apr 7, 2022 · 0 comments
Open

Drop DC_P and DC_OAI datastreams #69

giulioturetta opened this issue Apr 7, 2022 · 0 comments

Comments

@giulioturetta
Copy link
Contributor

giulioturetta commented Apr 7, 2022

Consider dropping DC_P and DC_OAI functional logic as the two data streams aren't useful anymore.

DC_P and DC_OAI data streams are created (or updated) every time update DC https://github.com/phaidra/phaidra-api/wiki/Documentation#update-dc is called whether or not updatedc hook is enabled or disabled in Phaidra API config.

Also, the two calls:

$r->route('object/:pid/dc') -> via('get') -> to('dc#get', dsid => 'DC_P');
$r->route('object/:pid/oai_dc') -> via('get') -> to('dc#get', dsid => 'DC_OAI');

do not make much sense when DC_P and DC_OAI data streams don't exist.

@giulioturetta giulioturetta changed the title Drop DC_P and DC_OAI Drop DC_P and DC_OAI datastreams Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant