hexToByteArray adding length of hex to Array

[ShamanBlackout]

[src/core/utils/index.ts]

current code

export function hexToByteArray(hexBytes: string) {
  const res = [hexBytes.length / 2]; //The issue
  for (let i = 0; i < hexBytes.length; i += 2) {
    const hexdig = hexBytes.substr(i, 2); //substr is deprecated
    if (hexdig == '') {
      res.push(0);
    } else res.push(parseInt(hexdig, 16));
  }
  return res;
}

• As you can see the hexBytes.length / 2 will be the first element of the array thus invalidating the valid hex

• substr is deprecated as well

• I suggest the following script

export function hexToByteArray(hexBytes: string) {
  let res = [];
  for (let i = 0; i < hexBytes.length; i += 2) {
    const hexdig = hexBytes.substring(i, i+2);
    if (hexdig == '') {
      res.push(0);
    } else res.push(parseInt(hexdig, 16));
  }
  return res;