New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant codes in configuration #1

Open

altunyurt opened this issue Oct 6, 2015 · 0 comments

Collaborator

altunyurt commented Oct 6, 2015

Ex: https://github.com/pharzan/MithChosen/blob/master/MithList.js#L35

        if (param['itemsPerPage']) {
            this.config['itemsPerPage'] = param['itemsPerPage']
        }

This one and similar codes are unnecessary . You can just use

for(key in param){
    this.config[key] = param[key]
}

or use an extend function, such as lodash or underscore's.

altunyurt mentioned this issue

Keep up with a naming convention #2

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment