Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save tagged needs fixing #49

Closed
phastmike opened this issue Sep 18, 2023 · 2 comments
Closed

Save tagged needs fixing #49

phastmike opened this issue Sep 18, 2023 · 2 comments

Comments

@phastmike
Copy link
Owner

Save tagged lines works only if we are hiding untagged lines (based on that model). A workaround fix is to enable the hide_untagged_lines method before saving. Another option is to keep track if line is tagged but will have more overhead.

@phastmike phastmike reopened this Jan 5, 2024
@phastmike
Copy link
Owner Author

hide_untagged_lines toggles state and not always the same result. This may lead to showing all lines (if already hiding untagged) which results in a similar file as the original one.

@phastmike
Copy link
Owner Author

phastmike commented Jun 4, 2024

Fix for the workaround - dev branch ( commit: 14a13b5 ). Needs better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant