Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what is the current state of this library? #29

Open
eventhorizonpl opened this issue Sep 1, 2021 · 2 comments
Open

what is the current state of this library? #29

eventhorizonpl opened this issue Sep 1, 2021 · 2 comments

Comments

@eventhorizonpl
Copy link

Hi @phayes

I would like to ask what is the state of this library? Are you interested in maintaing it? I noticed that it uses an older rsa crate version. I can try to update it and send you PR if you are interested in maintaining this library.

Best regards,
Michal

@eventhorizonpl
Copy link
Author

@phayes

I tried to update dependencies, but I've got one problem with type

cargo test
   Compiling rsa-fdh v0.4.1 (/home/michal/projects/kingdom/rsa-fdh)
error[E0308]: mismatched types
  --> src/common.rs:47:13
   |
47 |             &zero,
   |             ^^^^^ expected struct `num_bigint_dig::biguint::BigUint`, found struct `BigUint`
   |
   = note: expected reference `&num_bigint_dig::biguint::BigUint`
              found reference `&BigUint`
   = note: perhaps two different versions of crate `num_bigint_dig` are being used?

I noticed that fdh library has dependency on "num-bigint-dig 0.6.1". Do you think that updating this dependency would help to solve this problem? I updated it on my local copy of fdh and tests passes fine. Should I send you a PR?

Best regards,
Michał

@eventhorizonpl
Copy link
Author

@phayes

I created a PR for fdh-rs that is needed by this update phayes/fdh-rs#24

I'll send PR for rsa-fdh after you merge fdh-rs. I tested these changes on my forked versions.

Best regards,
Michal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant