From ad7d935de0101732af7436519769b0be206ed8ad Mon Sep 17 00:00:00 2001 From: Yngrid Coello Date: Fri, 6 Sep 2024 12:49:27 +0200 Subject: [PATCH] [Dataset quality] removing empty prompt (#192089) The empty prompt as of now is just informative After introducing other dataStream types within the page, the empty prompt became a hindrance in the UX preventing users to properly select a dataStream type when they have no data related to that type in the environment. This PR is about removing the empty prompt in favour of an empty state. We want to keep the prompt only in case we have a place where to redirect users to add relevant data ([ref](https://github.com/elastic/kibana/issues/191821)). ### Before https://github.com/user-attachments/assets/f294e37e-3a4e-430a-acd4-73a7acd21178 ### After https://github.com/user-attachments/assets/c24cd62b-0fc0-4a94-8f45-d8f7ec4da6f1 --- .../empty_state/empty_state.tsx | 29 +------------------ .../public/hooks/use_empty_state.ts | 12 +------- .../translations/translations/fr-FR.json | 2 -- .../translations/translations/ja-JP.json | 2 -- .../translations/translations/zh-CN.json | 2 -- .../page_objects/dataset_quality.ts | 2 +- 6 files changed, 3 insertions(+), 46 deletions(-) diff --git a/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/empty_state/empty_state.tsx b/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/empty_state/empty_state.tsx index 9ff2982098498..1fabd455ec9c2 100644 --- a/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/empty_state/empty_state.tsx +++ b/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/empty_state/empty_state.tsx @@ -16,7 +16,7 @@ import { useEmptyState } from '../../../hooks/use_empty_state'; // Allow for lazy loading // eslint-disable-next-line import/no-default-export export default function EmptyStateWrapper({ children }: { children: React.ReactNode }) { - const { canReadDataset, isDatasetEmpty } = useEmptyState(); + const { canReadDataset } = useEmptyState(); if (!canReadDataset) { return ( @@ -46,32 +46,5 @@ export default function EmptyStateWrapper({ children }: { children: React.ReactN ); } - if (isDatasetEmpty) { - return ( - - {i18n.translate('xpack.datasetQuality.emptyState.noData.title', { - defaultMessage: 'No datasets found', - })} - - } - body={ -

- {DEFAULT_LOGS_DATA_VIEW}, - }} - /> -

- } - /> - ); - } - return <>{children}; } diff --git a/x-pack/plugins/observability_solution/dataset_quality/public/hooks/use_empty_state.ts b/x-pack/plugins/observability_solution/dataset_quality/public/hooks/use_empty_state.ts index f60a7914275be..89ef4b884095d 100644 --- a/x-pack/plugins/observability_solution/dataset_quality/public/hooks/use_empty_state.ts +++ b/x-pack/plugins/observability_solution/dataset_quality/public/hooks/use_empty_state.ts @@ -14,15 +14,5 @@ export function useEmptyState() { service, (state) => state.context.datasetUserPrivileges.canRead ); - - const isDatasetEmpty = useSelector( - service, - (state) => - !state.matches('stats.datasets.fetching') && - !state.matches('integrations.fetching') && - !state.matches('stats.degradedDocs.fetching') && - (state.context.datasets?.length ?? 0) === 0 - ); - - return { canReadDataset, isDatasetEmpty }; + return { canReadDataset }; } diff --git a/x-pack/plugins/translations/translations/fr-FR.json b/x-pack/plugins/translations/translations/fr-FR.json index 6b67be558d471..2fb444ad60020 100644 --- a/x-pack/plugins/translations/translations/fr-FR.json +++ b/x-pack/plugins/translations/translations/fr-FR.json @@ -14610,8 +14610,6 @@ "xpack.datasetQuality.degradedDocsColumnName": "Documents dégradés (%)", "xpack.datasetQuality.degradedDocsColumnTooltip": "Le pourcentage de documents avec la propriété {ignoredProperty} dans votre ensemble de données.", "xpack.datasetQuality.degradedDocsQualityDescription": "{quality} -{comparator} {minimimPercentage}%", - "xpack.datasetQuality.emptyState.noData.message": "Aucun log d'ensemble de données n'a été trouvé. Pour commencer, assurez-vous d'avoir des logs de flux de données disponibles correspondant à {datasetPattern}.", - "xpack.datasetQuality.emptyState.noData.title": "Aucun ensemble de données trouvé", "xpack.datasetQuality.emptyState.noPrivileges.message": "Vous ne disposez pas des autorisations requises pour voir les données de logs. Assurez-vous d'avoir les autorisations requises pour voir {datasetPattern}.", "xpack.datasetQuality.emptyState.noPrivileges.title": "Impossible de charger les ensembles de données", "xpack.datasetQuality.fetchDatasetStatsFailed": "Nous n'avons pas pu obtenir vos ensembles de données.", diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json index d393af049ecd8..b9c6d9ab1758c 100644 --- a/x-pack/plugins/translations/translations/ja-JP.json +++ b/x-pack/plugins/translations/translations/ja-JP.json @@ -14599,8 +14599,6 @@ "xpack.datasetQuality.degradedDocsColumnName": "劣化したドキュメント（%）", "xpack.datasetQuality.degradedDocsColumnTooltip": "データセットにおける{ignoredProperty}プロパティのドキュメントの割合。", "xpack.datasetQuality.degradedDocsQualityDescription": "{quality} -{comparator} {minimimPercentage}%", - "xpack.datasetQuality.emptyState.noData.message": "ログデータセットが見つかりません。開始するには、{datasetPattern}と一致するログデータストリームがあることを確認してください。", - "xpack.datasetQuality.emptyState.noData.title": "データセットが見つかりません", "xpack.datasetQuality.emptyState.noPrivileges.message": "ログデータを表示するために必要な権限がありません。{datasetPattern}を表示するための十分な権限があることを確認してください。", "xpack.datasetQuality.emptyState.noPrivileges.title": "データセットを読み込めませんでした", "xpack.datasetQuality.fetchDatasetStatsFailed": "データセットを取得できませんでした。", diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json index b6edb38251ae1..a573ea4868a10 100644 --- a/x-pack/plugins/translations/translations/zh-CN.json +++ b/x-pack/plugins/translations/translations/zh-CN.json @@ -14622,8 +14622,6 @@ "xpack.datasetQuality.degradedDocsColumnName": "已降级文档 (%)", "xpack.datasetQuality.degradedDocsColumnTooltip": "您的数据集中包含 {ignoredProperty} 属性的文档的百分比。", "xpack.datasetQuality.degradedDocsQualityDescription": "{quality} -{comparator} {minimimPercentage}%", - "xpack.datasetQuality.emptyState.noData.message": "找不到日志数据集。要开始，请确保具有与 {datasetPattern} 匹配的可用日志数据流。", - "xpack.datasetQuality.emptyState.noData.title": "找不到数据集", "xpack.datasetQuality.emptyState.noPrivileges.message": "您没有查看日志数据所需的权限。请确保您具有足够的权限，可以查看 {datasetPattern}。", "xpack.datasetQuality.emptyState.noPrivileges.title": "无法加载数据集", "xpack.datasetQuality.fetchDatasetStatsFailed": "无法获取数据集。", diff --git a/x-pack/test/functional/page_objects/dataset_quality.ts b/x-pack/test/functional/page_objects/dataset_quality.ts index 29dd452c7592c..437aa6e2640d5 100644 --- a/x-pack/test/functional/page_objects/dataset_quality.ts +++ b/x-pack/test/functional/page_objects/dataset_quality.ts @@ -120,7 +120,7 @@ export function DatasetQualityPageObject({ getPageObjects, getService }: FtrProv datasetQualityDetailsIntegrationRowVersion: 'datasetQualityDetailsFieldsList-version', datasetQualityDetailsLinkToDiscover: 'datasetQualityDetailsLinkToDiscover', datasetQualityInsufficientPrivileges: 'datasetQualityInsufficientPrivileges', - datasetQualityNoDataEmptyState: 'datasetQualityNoDataEmptyState', + datasetQualityNoDataEmptyState: 'datasetQualityTableNoData', datasetQualityNoPrivilegesEmptyState: 'datasetQualityNoPrivilegesEmptyState', superDatePickerToggleQuickMenuButton: 'superDatePickerToggleQuickMenuButton',