Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I play60 mini pro patches #782

Open
wants to merge 3 commits into
base: pie
Choose a base branch
from

Conversation

keee-toy
Copy link

No description provided.

@keee-toy
Copy link
Author

keee-toy commented Aug 3, 2024

This pull request adds device-specific overlays and patches for the iPlay60 Mini Pro. The changes include:

  • Enhanced audio settings in mixer_paths.xml and audio_effects.conf to improve sound quality.
  • Adjustments in media_profiles.xml for better video quality.
  • Updated camera_config.xml to optimize camera performance.
  • General configurations in build.prop for improved device functionality.

These changes aim to enhance the overall user experience on the iPlay60 Mini Pro device.

@phhusson
Copy link
Owner

phhusson commented Sep 2, 2024

That's really not how the overlays here work.
Notably you're doing LOCAL_MODULE_PATH := $(TARGET_OUT_VENDOR)/overlay but we don't generate TARGET_OUT_VENDOR in GSI

That being said, (some) your changes could be useful, and we can discuss how to integrate them.

I'd say to start with audio: Can you share the diff before/after of mixer_paths.xml and audio_effects.conf so I understand what you changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants