Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap J and K when Firefox is using vertical tabs #4648

Open
mfbehrens opened this issue Mar 13, 2025 · 6 comments
Open

Swap J and K when Firefox is using vertical tabs #4648

mfbehrens opened this issue Mar 13, 2025 · 6 comments

Comments

@mfbehrens
Copy link

Describe the bug

When using vertical tabs on Firefox J goes to the previous tab which is above the current and K goes to the next which is below. This is opposite to how it would work in vim.

Suggestion

A toggle button to swap J and K would probably be the best solution.

Browser and Vimium version

Name 	Firefox
Version 	136.0
Build-ID 	20250303224729
Distributions-ID 	archlinux
User-Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:136.0) Gecko/20100101 Firefox/136.0

Vimium version 2.1.2

If you're using Chrome, include the Chrome and OS version found at chrome://version. Also include
the Vimium version found at chrome://extensions.

If you're using Firefox, report the Firefox and OS version found at about:support. Also include the
Vimium version found at about:addons.

@philg-dev
Copy link
Contributor

This is a duplicate of:

map J nextTab
map K previousTab

@UncleSnail
Copy link
Contributor

There may be a way to detect vertical tabs and do the swap automatically, but that could confuse users who know what they are doing. I also ran into this problem but did the manual mapping, so it would break my config.

Adding an option seems unnecessary because we can just map manually. A potentially better idea would be to add a section to the "help" or "faq" about vertical tabs with that suggested mapping so that users know what how to easily fix the vertical tab confusion in the future.

@mfbehrens
Copy link
Author

Maybe adding the config commented out as the default config value could 1) be more helpful than # Insert your preferred key mappings here. and 2) be the one configuration a lot of users will need to fix their Vimium, but that is just my opinion.

@UncleSnail
Copy link
Contributor

Maybe adding the config commented out as the default config value could 1) be more helpful than # Insert your preferred key mappings here. and 2) be the one configuration a lot of users will need to fix their Vimium, but that is just my opinion.

That could be a good idea as an example config to give to show how one should be laid out, and as something many people might want in their config. I do like the practice in many Linux programs of having commented out "standard" configs with the most common things people want to change, so others might also like that with Vimium. The obvious question then becomes, how do we determine what gets to go in the standard config and what doesn't?

@kbilsted
Copy link

For starters I prefer w for next pane and b for previous.. much nicer than using ahift.

I thought J and K was good, but this is easier. Especially when having the mouse in the other hand

@UncleSnail
Copy link
Contributor

For starters I prefer w for next pane and b for previous.. much nicer than using ahift.

I thought J and K was good, but this is easier. Especially when having the mouse in the other hand

This is exactly why I'm proposing that if possible we need to decide what is a "user preference" and what is a "common config". Because people could argue all day about this, lol.

I would consider w/b to be completely user preference that has no other "reason" to go in a default config, whereas j/k swap has some justification in that it fixes a common problem, ie: vertical tabs feeling backwards. Are there other "justifiable" things that we could add to a default config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants