In link-hint filtering mode, the link is not activated even though 'Require Enter' is unchecked

[roeniss]

Describe the bug

In link-hint filtering mode, the doc says "if there's only one candidate left, the link will be activate automatically" (ref), but it doesn't.

In Vimium options - Miscellaneous options, I did:

• check: Use the link's name and characters for link-hint filtering
• uncheck: Require Enter when filtering hints

Expected behavior

When there's only one applicable link left, the link is activated automatically.

Side note

• When I checked Use the link's name and characters for link-hint filtering, Characters used for link hints is changed to 0123456789
• When there become only one link by typing digits, it activated automatically.

To Reproduce

Steps to reproduce the behavior:

1. Set two options like above
2. Open https://github.com/philc/vimium
3. f -> pu
4. There is (I hope) only one link left, the 'Pull Request' tab. but it only get highlighted and not activated. To activate the link, I have to type additional 1.

Verions

• Chrome: 134.0.6998.89 (arm64)
• Vimium: 2.1.2

[UncleSnail]

I can confirm, I seem to be getting this bug as well in Firefox. The link becomes highlighted so that either "enter" or "1" will follow.
(Note that in my tests, using pu is not enough to get a single result as in the reproduce steps. There is a 2nd result. However, on other tests, the behavior does seem wrong.)

[roeniss]

using pu is not enough to get a single result as in the reproduce steps

I also found that pu is not enough, yeah...

f -> pul -> 'Pull Request' tab becomes like focused state, but never activated (like clicked)

picture 1: pu

picture 2: pul (focused)

picture 3: pull (focused... more?)

(The more I typed, the darker it gets. I'm not sure if it's spec or not)

[UncleSnail]

(The more I typed, the darker it gets. I'm not sure if it's spec or not)

That does honestly sound like a "bug" of being re-highlighted with each new character, but it could be intentional. I don't feel like looking into it because it doesn't seem like a big deal at the moment. If someone else wants to confirm this is happening and fix the issue if it is one, that could be good.

[roeniss]

I agree with you. For this issue, let's focus on the original one only.