openCopiedUrlInCurrentTab and openCopiedUrlInNewTab no longer launch search query

[gnarendran]

Describe the bug

Previously p and P conveniently used to launch a search query for the copied STRING if it wasn't a URL. Now I only get a console log such as "convertToUrl: can't convert "STRING" into a URL. This shouldn't happen." and a new tab.

The former behavior was really useful, which makes me wonder if the new behavior of enforcing the STRING to be an URL, is intentional.

Browser and Vimium version
chrome: 134.0.6998.88 (Official Build) (64-bit)
vimium: 2.2.1

[XOKP]

It appears that the URL also isn’t opening anymore.

[gnarendran]

It appears that the URL also isn’t opening anymore.

That should be version 2.2.0_1. In 2.2.1 that has been fixed, but this issue is still seen.

[philg-dev]

Duplicate of #4654

[NI57721]

I have the same issue here.

@philg-dev
I know #4654 was fixed and that it works well now (great thanks!), but this is a different issue.
What was said in #4654 was a bug of p and P when you have a URL string in your clipboard.
On the other hand, this issue says a bug when you have a non-URL string.
I'm going to search for the cause.

[NI57721]

This function seems to have been removed in 0fec088 (c.f. #4439)
I'm not sure if the change of the behaviour of p and P was intended.

[philg-dev]

On the other hand, this issue says a bug when you have a non-URL string.

Oh, you're right - I'm sorry, I jumped the gun there and misread it.