From 8484e27b2781e184546de5585c48b9af8a292c65 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20Gill=C3=A9?= <philipp.gille@gmail.com>
Date: Mon, 18 Mar 2024 23:06:04 +0100
Subject: [PATCH] Improve loading of persistent DB

- Skip non-chromem directories
- Error when metadata is missing
---
 db.go | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/db.go b/db.go
index 50c4606..74e550e 100644
--- a/db.go
+++ b/db.go
@@ -98,9 +98,10 @@ func NewPersistentDB(path string) (*DB, error) {
 			return nil, fmt.Errorf("couldn't read collection directory: %w", err)
 		}
 		c := &Collection{
-			// We can fill Name, persistDirectory and metadata only after reading
+			persistDirectory: collectionPath,
+			documents:        make(map[string]*Document),
+			// We can fill Name and metadata only after reading
 			// the metadata.
-			documents: make(map[string]*Document),
 			// We can fill embed only when the user calls DB.GetCollection() or
 			// DB.GetOrCreateCollection().
 		}
@@ -124,7 +125,6 @@ func NewPersistentDB(path string) (*DB, error) {
 					return nil, fmt.Errorf("couldn't read collection metadata: %w", err)
 				}
 				c.Name = pc.Name
-				c.persistDirectory = filepath.Dir(collectionPath)
 				c.metadata = pc.Metadata
 			} else if filepath.Ext(collectionDirEntry.Name()) == ".gob" {
 				// Read document
@@ -139,6 +139,16 @@ func NewPersistentDB(path string) (*DB, error) {
 				continue
 			}
 		}
+		// If we have neither name nor documents, it was likely a user-added
+		// directory, so skip it.
+		if c.Name == "" && len(c.documents) == 0 {
+			continue
+		}
+		// If we have no name, it means there was no metadata file
+		if c.Name == "" {
+			return nil, fmt.Errorf("collection metadata file not found: %s", collectionPath)
+		}
+
 		db.collections[c.Name] = c
 	}