From e2361ab0b521beec5bc3766d3c643c195f147a32 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philipp=20Gill=C3=A9?= Date: Fri, 19 Jul 2019 22:42:50 +0200 Subject: [PATCH] Skip compressing `serve` executable for macOS - Until UPX v3.96 is released For #27 --- build/build.ps1 | 3 ++- build/build.sh | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/build/build.ps1 b/build/build.ps1 index 0e5f9c6..4699b8d 100644 --- a/build/build.ps1 +++ b/build/build.ps1 @@ -56,7 +56,8 @@ $env:GOARCH = $go_arch_backup if (!$noUpx.IsPresent) { upx --ultra-brute "${artifactsDir}\serve_v${version}_Windows_x64\serve.exe" - upx --ultra-brute "${artifactsDir}\serve_v${version}_macOS_x64\serve" + # Leads to a broken executable when using UPX v3.95. See https://github.com/upx/upx/issues/222. + #upx --ultra-brute "${artifactsDir}\serve_v${version}_macOS_x64\serve" upx --ultra-brute "${artifactsDir}\serve_v${version}_Linux_x64\serve" } diff --git a/build/build.sh b/build/build.sh index aa99c85..cf8bcea 100755 --- a/build/build.sh +++ b/build/build.sh @@ -33,7 +33,8 @@ GOOS=linux GOARCH=amd64 go build -v -o "${ARTIFACTSDIR}/serve_v${VERSION}_Linux_ # Requires UPX to be installed (for example with "apt install upx-ucl"). if [[ "$NO_UPX" == "false" ]]; then upx --ultra-brute "${ARTIFACTSDIR}/serve_v${VERSION}_Windows_x64/serve.exe" - upx --ultra-brute "${ARTIFACTSDIR}/serve_v${VERSION}_macOS_x64/serve" + # Leads to a broken executable when using UPX v3.95. See https://github.com/upx/upx/issues/222. + #upx --ultra-brute "${ARTIFACTSDIR}/serve_v${VERSION}_macOS_x64/serve" upx --ultra-brute "${ARTIFACTSDIR}/serve_v${VERSION}_Linux_x64/serve" fi