Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken test files still pass #72

Open
phillord opened this issue Mar 13, 2024 · 2 comments
Open

Broken test files still pass #72

phillord opened this issue Mar 13, 2024 · 2 comments
Assignees
Labels
bug Something isn't working testing Tests that need to be added/changed/automated
Milestone

Comments

@phillord
Copy link
Owner

I have modified "class.owx" to contain this obvious breakage.

   <Prefix name="rdfs" IRI="http://www.w3.org/2000/01/rdf-schema#"/>
    
    I am broken


    <Declaration>
        <Class IRI="#C"/>
    </Declaration>

But, obvious as it is, the tests all seem to pass and I do not know why.

@filippodebortoli
Copy link
Collaborator

filippodebortoli commented Mar 15, 2024

By looking at io::ows::reader::read_with_build it becomes clearer that anything that is not a opening/closing or an empty tag is simply not handled, via the case _ => {} (code here).

This means that the text "I am broken" you inserted is just filtered away while parsing, as of now.

@phillord
Copy link
Owner Author

Ah, that is good to know, since I may need to break an ontology again (as I did when I discovered this). I will think on it. In some ways the behaviour is nice (i.e. it still works) but in others bad. Horned does not have a generic mechanism for logging or reactiing to this sort of partial error.

@phillord phillord self-assigned this Mar 17, 2024
@filippodebortoli filippodebortoli added this to the 1.0 milestone Mar 25, 2024
@filippodebortoli filippodebortoli added testing Tests that need to be added/changed/automated bug Something isn't working labels May 15, 2024
@phillord phillord modified the milestones: 1.0, 1.* May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing Tests that need to be added/changed/automated
Projects
None yet
Development

No branches or pull requests

2 participants