Working on removing git lfs.

Author: jzonthemtn

.gitignore

@@ -16,3 +16,5 @@ distribution/indexes
 distribution/documentation/
 manifest.json
 .attach_*
+*.onnx
+vocab.txt

download-models.sh

@@ -0,0 +1,6 @@
+#!/bin/bash -e
+
+# todo: download onnx model
+cp model.onnx ./phileas/phileas-core/src/test/resources/models/model.onnx
+cp model.onnx ./phileas-services/phileas-services-ai/src/test/resources/models/model.onnx
+

phileas-core/src/test/java/ai/philterd/test/phileas/services/filters/PersonsV2FilterTest.java

@@ -33,6 +33,7 @@
 import org.mockito.Mockito;
 
 import java.io.File;
+import java.net.URISyntaxException;
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
@@ -44,13 +45,15 @@ public class PersonsV2FilterTest extends AbstractFilterTest {
 
     private static final Logger LOGGER = LogManager.getLogger(PersonsV2FilterTest.class);
 
-    private AlertService alertService = Mockito.mock(AlertService.class);
-    private MetricsService metricsService = Mockito.mock(MetricsService.class);
+    private final AlertService alertService = Mockito.mock(AlertService.class);
+    private final MetricsService metricsService = Mockito.mock(MetricsService.class);
 
     @Test
     @DisabledOnOs({WINDOWS, MAC})
     public void filter1() throws Exception {
 
+        Assertions.assertTrue(modelFilesExist());
+
         final FilterConfiguration filterConfiguration = new FilterConfiguration.FilterConfigurationBuilder()
                 .withStrategies(List.of(new PersonsFilterStrategy()))
                 .withAlertService(alertService)
@@ -84,6 +87,8 @@ public void filter1() throws Exception {
     @DisabledOnOs({WINDOWS, MAC})
     public void filter2() throws Exception {
 
+        Assertions.assertTrue(modelFilesExist());
+
         final FilterConfiguration filterConfiguration = new FilterConfiguration.FilterConfigurationBuilder()
                 .withStrategies(List.of(new PersonsFilterStrategy()))
                 .withAlertService(alertService)
@@ -124,6 +129,8 @@ public void filter2() throws Exception {
     @DisabledOnOs({WINDOWS, MAC})
     public void filter3() throws Exception {
 
+        Assertions.assertTrue(modelFilesExist());
+
         final FilterConfiguration filterConfiguration = new FilterConfiguration.FilterConfigurationBuilder()
                 .withStrategies(List.of(new PersonsFilterStrategy()))
                 .withAlertService(alertService)
@@ -152,16 +159,14 @@ public void filter3() throws Exception {
 
         Assertions.assertEquals(3, filterResult.getSpans().size());
 
-        //Assertions.assertTrue(checkSpanInSpans(filterResult.getSpans(), 1181, 1194, FilterType.PERSON, "Reverend King", "{{{REDACTED-person}}}"));
-        //Assertions.assertTrue(checkSpanInSpans(filterResult.getSpans(), 1154, 1175, FilterType.PERSON, "Barbara Ferrer Ferrer", "{{{REDACTED-person}}}"));
-        //Assertions.assertTrue(checkSpanInSpans(filterResult.getSpans(), 1043, 1061, FilterType.PERSON, "Martin Luther King", "{{{REDACTED-person}}}"));
-
     }
 
     @Test
     @DisabledOnOs({WINDOWS, MAC})
     public void filter4() throws Exception {
 
+        Assertions.assertTrue(modelFilesExist());
+
         final FilterConfiguration filterConfiguration = new FilterConfiguration.FilterConfigurationBuilder()
                 .withStrategies(List.of(new PersonsFilterStrategy()))
                 .withAlertService(alertService)
@@ -196,6 +201,8 @@ public void filter4() throws Exception {
     @DisabledOnOs({WINDOWS, MAC})
     public void filter5() throws Exception {
 
+        Assertions.assertTrue(modelFilesExist());
+
         final FilterConfiguration filterConfiguration = new FilterConfiguration.FilterConfigurationBuilder()
                 .withStrategies(List.of(new PersonsFilterStrategy()))
                 .withAlertService(alertService)
@@ -232,6 +239,8 @@ public void filter5() throws Exception {
     @DisabledOnOs({WINDOWS, MAC})
     public void filter6() throws Exception {
 
+        Assertions.assertTrue(modelFilesExist());
+
         final FilterConfiguration filterConfiguration = new FilterConfiguration.FilterConfigurationBuilder()
                 .withStrategies(List.of(new PersonsFilterStrategy()))
                 .withAlertService(alertService)
@@ -264,4 +273,18 @@ public void filter6() throws Exception {
 
     }
 
+    private boolean modelFilesExist() throws URISyntaxException {
+
+        try {
+            new File(getClass().getClassLoader().getResource("models/model.onnx").toURI());
+            new File(getClass().getClassLoader().getResource("models/vocab.txt").toURI());
+        } catch (NullPointerException ex) {
+            LOGGER.warn("Unable to read the required models/model.onnx and/or models.vocab.txt for unit test. Ensure both files exist.");
+            return false;
+        }
+
+        return true;
+
+    }
+
 }