#116 Creating a constant for SAME.

Author: jzonthemtn

phileas-model/src/main/java/ai/philterd/phileas/model/policy/filters/strategies/AbstractFilterStrategy.java

@@ -23,11 +23,8 @@
 import ai.philterd.phileas.model.policy.FPE;
 import ai.philterd.phileas.model.policy.Policy;
 import ai.philterd.phileas.model.services.AnonymizationService;
-import ai.philterd.phileas.model.utils.Encryption;
 import com.google.gson.annotations.Expose;
 import com.google.gson.annotations.SerializedName;
-import org.apache.commons.codec.digest.DigestUtils;
-import org.apache.commons.lang3.RandomStringUtils;
 import org.apache.commons.lang3.StringUtils;
 
 import java.io.IOException;
@@ -46,6 +43,7 @@ public abstract class AbstractFilterStrategy {
     public static final String HASH_SHA256_REPLACE = "HASH_SHA256_REPLACE";
     public static final String LAST_4 = "LAST_4";
     public static final String MASK = "MASK";
+    public static final String SAME = AbstractFilterStrategy.SAME;
 
     // NER Person's name strategies
     public static final String ABBREVIATE = "ABBREVIATE";
@@ -107,7 +105,7 @@ public abstract class AbstractFilterStrategy {
 
     @SerializedName("maskLength")
     @Expose
-    protected String maskLength = "same";
+    protected String maskLength = SAME;
 
     @SerializedName("condition")
     @Expose

phileas-model/src/main/java/ai/philterd/phileas/model/policy/filters/strategies/StandardFilterStrategy.java

@@ -44,7 +44,7 @@ public Replacement getStandardReplacement(String label, String context, String d
 
             int characters = token.length();
 
-            if(!StringUtils.equalsIgnoreCase(maskLength, "same")) {
+            if(!StringUtils.equalsIgnoreCase(maskLength, AbstractFilterStrategy.SAME)) {
                 characters = Integer.parseInt(maskLength);
             }
 

phileas-model/src/main/java/ai/philterd/phileas/model/policy/filters/strategies/ai/PersonsFilterStrategy.java

@@ -146,7 +146,7 @@ public Replacement getReplacement(String label, String context, String documentI
 
             int characters = token.length();
 
-            if(!StringUtils.equalsIgnoreCase(maskLength, "same")) {
+            if(!StringUtils.equalsIgnoreCase(maskLength, AbstractFilterStrategy.SAME)) {
                 characters = Integer.parseInt(maskLength);
             }
 

phileas-model/src/main/java/ai/philterd/phileas/model/policy/filters/strategies/rules/DateFilterStrategy.java

@@ -164,7 +164,7 @@ public Replacement getReplacement(String label, String context, String documentI
 
             int characters = token.length();
 
-            if(!StringUtils.equalsIgnoreCase(maskLength, "same")) {
+            if(!StringUtils.equalsIgnoreCase(maskLength, AbstractFilterStrategy.SAME)) {
                 characters = Integer.parseInt(maskLength);
             }
 

phileas-model/src/main/java/ai/philterd/phileas/model/policy/filters/strategies/rules/ZipCodeFilterStrategy.java

@@ -173,7 +173,7 @@ public Replacement getReplacement(String label, String context, String documentI
 
             int characters = token.length();
 
-            if(!StringUtils.equalsIgnoreCase(maskLength, "same")) {
+            if(!StringUtils.equalsIgnoreCase(maskLength, AbstractFilterStrategy.SAME)) {
                 characters = Integer.parseInt(maskLength);
             }
 

phileas-model/src/test/java/ai/philterd/test/phileas/model/policy/filters/strategies/AbstractFilterStrategyTest.java

@@ -240,7 +240,7 @@ public void replacementWithMaskCharacterForSameLength() throws Exception {
 
         final AbstractFilterStrategy strategy = getFilterStrategy();
         strategy.setStrategy(AbstractFilterStrategy.MASK);
-        strategy.setMaskLength("same");
+        strategy.setMaskLength(AbstractFilterStrategy.SAME);
 
         final String token = "token";
         final Replacement replacement = strategy.getReplacement("name", "context", "docId", token, WINDOW, null, null, anonymizationService, null);