Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of location permissions inside app state #550

Open
GV14982 opened this issue Dec 11, 2024 · 2 comments
Open

Keep track of location permissions inside app state #550

GV14982 opened this issue Dec 11, 2024 · 2 comments
Assignees
Labels
Version 2 Features to be developed for Version 2.0 of the PHLASK App

Comments

@GV14982
Copy link
Contributor

GV14982 commented Dec 11, 2024

Is your feature request related to a problem? Please describe.
Right now if you deny the app location access, it seems to just assume you're at city hall. This conflicts with the new "Near Me" feature.

Describe the solution you'd like
We should add some logic to keep track of whether or not we have access to a user's location. This would allow us to dynamically enable/disable features based on that data to reduce undefined behavior in the app.

Describe alternatives you've considered

Additional context
Spoke with @affabillyty at the December Hack Night and this seems to be a pretty pressing concern. This will require a follow up ticket specifically for the "Near Me" button to be disabled based on location status.

@GV14982 GV14982 added the Version 2 Features to be developed for Version 2.0 of the PHLASK App label Dec 11, 2024
@GV14982 GV14982 self-assigned this Dec 11, 2024
@GV14982
Copy link
Contributor Author

GV14982 commented Dec 11, 2024

One limitation of my current implementation of this is that Firefox "temporary permissions" don't change the permission state like other browsers, so if a user doesn't check the "Remember this option" box on the prompt, it will be stuck in a sort of limbo.

Bugzilla ticket for reference: https://bugzilla.mozilla.org/show_bug.cgi?id=1719651

I would love some suggestions for if I should even worry about this (I'm probably an outlier in that I generally use temp perms).

@affabillyty @gcardonag @RNR1

@gcardonag
Copy link
Contributor

I know we talked about this on standup, so capturing it here for future reference. It seems like we should explore this from a user experience perspective.

In my opinion, this is definitely more of a good-to-have than a need-to-have, so no need to suffer too much if this becomes difficult to explore. I generally appreciate Firefox's approach to location sharing as it helps me when testing to use our default location

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Version 2 Features to be developed for Version 2.0 of the PHLASK App
Projects
Status: No status
Development

No branches or pull requests

2 participants