Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource Confirmation Modal for Desktop #418

Open
tomporvaz opened this issue Apr 17, 2024 · 4 comments · May be fixed by #553
Open

Add Resource Confirmation Modal for Desktop #418

tomporvaz opened this issue Apr 17, 2024 · 4 comments · May be fixed by #553
Assignees
Labels
Desktop good first issue Good for newcomers Version 2 Features to be developed for Version 2.0 of the PHLASK App

Comments

@tomporvaz
Copy link
Contributor

Is your feature request related to a problem? Please describe.
For Phlask 2.0 we want to create a Confirmation Modal at the end of the Add Site workflow on the Desktop version of the map. After a user submits one of the Add Site forms they should be shown the Confirmation Modal.

Describe the solution you'd like
Desktop version: https://www.figma.com/file/VGGqwl3Eq3GQIAO9I6LoNW/PHLASK?type=design&node-id=8303-159839&mode=design&t=11QA6ewY33s590LH-0
image

Describe alternatives you've considered
n/a

Additional context
This is related to #314 where another team member is working on the crowdsourcing forms. The mobile version of this modal is being worked on in #341.

@tomporvaz tomporvaz added good first issue Good for newcomers Version 2 Features to be developed for Version 2.0 of the PHLASK App Desktop labels Apr 17, 2024
@tomporvaz tomporvaz moved this to 🔖 Ready in Phlask Map Apr 17, 2024
@tomporvaz tomporvaz moved this from 🔖 Ready to 🏗 In progress in Phlask Map Jun 18, 2024
@mandyshri101
Copy link
Collaborator

Hi @vontell and @tomporvaz: Any idea how will figma design be translated to code? I tried finding the code of @tomporvaz for the mobile. But was not able to find it. I will try once again but I am totally clueless how to start with this. Would need help of both of you in todays hack session. Thanks

@mandyshri101
Copy link
Collaborator

Hi everyone: Seems like the code is broken. When I click on any of the resources the add to site model does not populate. I will look into it why it does not populate. I can see src/components/AddResourceModal/ChooseResource.jsx file associated with it. Is there any other file I should be looking for that is associated with the addition of the form and confirmation model? Is the issue have been fixed just confirming.
Screenshot 2024-07-16 at 17 24 56

@mandyshri101
Copy link
Collaborator

mandyshri101 commented Jul 18, 2024

Whenever I am filling out the form for adding any resource site, I get the below error. I will look into what the issue is. @RNR1 Do you remember this issue was not there when we did this workflow on our last Hackathon? So I am not getting that submission feedback at all what we got when we submitted out ours shown in the first thread on this issue by @tomporvaz f
Screenshot 2024-07-17 at 21 28 01

@mandyshri101
Copy link
Collaborator

I updated the code again. Below is the bug I am getting on the latest code on my windows built. Will try to fix it otherwise would need someones help to resolve it. Thanks
image

@GV14982 GV14982 assigned GV14982 and unassigned GV14982 Oct 30, 2024
@gcardonag gcardonag self-assigned this Nov 10, 2024
@gcardonag gcardonag linked a pull request Dec 21, 2024 that will close this issue
@gcardonag gcardonag moved this from 🏗 In progress to 👀 In review in Phlask Map Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Desktop good first issue Good for newcomers Version 2 Features to be developed for Version 2.0 of the PHLASK App
Projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

4 participants