Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RTE model #14

Closed
SaintierFr opened this issue Mar 6, 2025 · 0 comments · Fixed by #18
Closed

Implement RTE model #14

SaintierFr opened this issue Mar 6, 2025 · 0 comments · Fixed by #18
Assignees
@ecieren

Comments

@SaintierFr
Copy link
Member

Describe the current behavior

No response

Describe the expected behavior

Reimplement old RTE model

Describe the motivation

No response

Extra Information

No response
SaintierFr added a commit that referenced this issue Mar 6, 2025
@SaintierFr
feat(#14): Implement RTE Solver
3f9fdf3 
- Add previous functional tests

Signed-off-by: SaintierFr <[email protected]>
SaintierFr added a commit that referenced this issue Mar 6, 2025
@SaintierFr
feat(#14): Implement RTE Solver
9de8801 
- Add previous functional tests

Signed-off-by: SaintierFr <[email protected]>
@ecieren ecieren mentioned this issue Mar 11, 2025
Merged
6 tasks
ecieren added a commit that referenced this issue Mar 11, 2025
@ecieren
Merge branch 'feature/#14/implement_rte_solver/from_main' of github.c…
ff03413 
…om:phlowers/thermohl into feature/#14/implement_rte_solver/from_main
SaintierFr added a commit that referenced this issue Mar 18, 2025
@SaintierFr
feat(#14): Implement basic 3 temperatures Solver
61cce2e 
- Add previous functional tests
- typo/error correction in transient temperature
- remove comments
- Added legacy 3t solver
- Working functional tests
- Code factorization and auto format
- Adapted tests for morgan coeff since not static anymore
- Update src/thermohl/solver/slv3t.py

Co-authored-by: SaintierFr <[email protected]>
Signed-off-by: Emmanuel Cieren <[email protected]>
SaintierFr added a commit that referenced this issue Mar 18, 2025
@SaintierFr
feat(#14): Implement basic 3 temperatures Solver
8089823 
- Add previous functional tests
- typo/error correction in transient temperature
- remove comments
- Added legacy 3t solver
- Working functional tests
- Code factorization and auto format
- Adapted tests for morgan coeff since not static anymore
- Update src/thermohl/solver/slv3t.py

Co-authored-by: SaintierFr <[email protected]>
Signed-off-by: Emmanuel Cieren <[email protected]>
SaintierFr added a commit that referenced this issue Mar 19, 2025
@SaintierFr
feat(#14): Implement basic 3 temperatures Solver
ca8a631 
- Add previous functional tests
- typo/error correction in transient temperature
- remove comments
- Added legacy 3t solver
- Working functional tests
- Code factorization and auto format
- Adapted tests for morgan coeff since not static anymore
- Update src/thermohl/solver/slv3t.py

Co-authored-by: SaintierFr <[email protected]>
Signed-off-by: Emmanuel Cieren <[email protected]>
SaintierFr added a commit that referenced this issue Mar 19, 2025
@SaintierFr
feat(#14): Implement basic 3 temperatures Solver
5975b0b 
- Add ReadTheDocs configuration for new solver

Signed-off-by: SaintierFr <[email protected]>
SaintierFr added a commit that referenced this issue Mar 20, 2025
@SaintierFr
feat(#14): Implement basic 3 temperatures Solver
39e774c 
- Add previous functional tests
- typo/error correction in transient temperature
- remove comments
- Added legacy 3t solver
- Working functional tests
- Code factorization and auto format
- Adapted tests for morgan coeff since not static anymore
- Update src/thermohl/solver/slv3t.py

Co-authored-by: SaintierFr <[email protected]>
Signed-off-by: Emmanuel Cieren <[email protected]>
SaintierFr added a commit that referenced this issue Mar 20, 2025
@SaintierFr
feat(#14): Implement basic 3 temperatures Solver
dc7ef4f 
- Add ReadTheDocs configuration for new solver

Signed-off-by: SaintierFr <[email protected]>
SaintierFr added a commit that referenced this issue Mar 20, 2025
@SaintierFr
feat(#14): Implement basic 3 temperatures Solver
9a86c19 
- Add ReadTheDocs configuration for new solver

Signed-off-by: SaintierFr <[email protected]>
SaintierFr added a commit that referenced this issue Mar 21, 2025
@SaintierFr
feat(#14): Implement basic 3 temperatures Solver
50f1ef1 
- Add previous functional tests
- typo/error correction in transient temperature
- remove comments
- Added legacy 3t solver
- Working functional tests
- Code factorization and auto format
- Adapted tests for morgan coeff since not static anymore
- Update src/thermohl/solver/slv3t.py

Co-authored-by: SaintierFr <[email protected]>
Signed-off-by: Emmanuel Cieren <[email protected]>
SaintierFr added a commit that referenced this issue Mar 21, 2025
@SaintierFr
feat(#14): Implement basic 3 temperatures Solver
7ac5e9c 
- Add ReadTheDocs configuration for new solver

Signed-off-by: SaintierFr <[email protected]>
SaintierFr added a commit that referenced this issue Mar 21, 2025
@SaintierFr
feat(#14): documentation and metadata for clarity and completeness
938c29b 
- Enhanced the README with clearer installation instructions and code block formatting.
- Expanded `pyproject.toml` with additional classifiers for better metadata representation, and corrected minor inconsistencies in the license field.

Signed-off-by: SaintierFr <[email protected]>
SaintierFr added a commit that referenced this issue Mar 24, 2025
@SaintierFr
feat(#14): improve naming and constants for clarity
e08f53c 
- Improved variable naming to enhance code readability and maintainability.
- Introduced `Final` constants for conductor coefficients, improving code semantics and preventing unintended modifications.

Signed-off-by: SaintierFr <[email protected]>
SaintierFr added a commit that referenced this issue Mar 24, 2025
@SaintierFr
feat(#14): improve naming and constants for clarity
275607e 
- Improved variable naming to enhance code readability and maintainability.
- Introduced `Final` constants for conductor coefficients, improving code semantics and preventing unintended modifications.

Signed-off-by: SaintierFr <[email protected]>
ecieren added a commit that referenced this issue Mar 26, 2025
@ecieren @SaintierFr
Feature/#14/implement rte solver/from main (#18)
6710bfa 
* fix(#16): Fix documentation and ReadTheDocs configuration

- Correct mkdocs file extension and update site_url to reflect the new project URL.
- Add the mkdocs-markdownextradata-plugin dependency to enhance markdown functionalities.
These changes ensure compatibility and proper documentation setup.

Signed-off-by: SaintierFr <[email protected]>

* feat(#14): Implement basic 3 temperatures Solver

- Add previous functional tests
- typo/error correction in transient temperature
- remove comments
- Added legacy 3t solver
- Working functional tests
- Code factorization and auto format
- Adapted tests for morgan coeff since not static anymore
- Update src/thermohl/solver/slv3t.py

Co-authored-by: SaintierFr <[email protected]>
Signed-off-by: Emmanuel Cieren <[email protected]>

* feat(#14): Implement basic 3 temperatures Solver

- Add ReadTheDocs configuration for new solver

Signed-off-by: SaintierFr <[email protected]>

* feat(#14): documentation and metadata for clarity and completeness

- Enhanced the README with clearer installation instructions and code block formatting.
- Expanded `pyproject.toml` with additional classifiers for better metadata representation, and corrected minor inconsistencies in the license field.

Signed-off-by: SaintierFr <[email protected]>

* feat(#14): improve naming and constants for clarity

- Improved variable naming to enhance code readability and maintainability.
- Introduced `Final` constants for conductor coefficients, improving code semantics and preventing unintended modifications.

Signed-off-by: SaintierFr <[email protected]>

---------

Signed-off-by: SaintierFr <[email protected]>
Signed-off-by: Emmanuel Cieren <[email protected]>
Co-authored-by: SaintierFr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ecieren ecieren

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/#14/implement rte solver/from main phlowers/thermohl
2 participants
@SaintierFr @ecieren