Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disruptive breaking change #72

Open
fiddlerwoaroof opened this issue Sep 23, 2022 · 1 comment · Fixed by fiddlerwoaroof/yason#2 · May be fixed by #73
Open

Disruptive breaking change #72

fiddlerwoaroof opened this issue Sep 23, 2022 · 1 comment · Fixed by fiddlerwoaroof/yason#2 · May be fixed by #73

Comments

@fiddlerwoaroof
Copy link

I use Yason extensively in my personal codebases and 7daea breaks all sorts of code that has been stable for years: before, yason would default to *standard-output* for encoding and now it defaults to the stream referenced by the unbound symbol *json-output*. This makes one of my primary use-cases (quickly testing things out at the repl) much more burdensome, because I have to either (setf yason::*json-output* *standard-output*) or add a bunch of boilerplate to make a json output stream.

The change itself makes sense because it makes :indent and friends less surprising but, IMO, it should be done in a non-breaking way.

@fiddlerwoaroof fiddlerwoaroof changed the title Major breaking change Disruptive breaking change Sep 23, 2022
fiddlerwoaroof added a commit to fiddlerwoaroof/yason that referenced this issue Sep 23, 2022
@phmarek
Copy link
Owner

phmarek commented Sep 26, 2022

Hi Ed,

to be honest, I quite like that YASON requires some setup - this way a wrong call-path is easier to notice.

Would you be okay with just doing a (SETF ...) in your code base, or does this behaviour affect too many of your projects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants