Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triangles of contact envelopes #1002

Open
matthiasfabry opened this issue Feb 11, 2025 · 0 comments
Open

Triangles of contact envelopes #1002

matthiasfabry opened this issue Feb 11, 2025 · 0 comments
Assignees
Labels
optimization Optimizes code without fundamentally changing any functionality

Comments

@matthiasfabry
Copy link
Collaborator

When modeling high-mass-ratio contact binaries, usually a high ntriangles is needed to accurately represent the small secondary component (and the neck region). However, using a single ntriangles over-samples the large primary, which (arguably unnecessarily) causes slow-downs in computes.

I believe this is not unimportant since many contact binaries are found to have extreme mass ratios.
Image

for q = 0.2, the default ntriangles is not enough.
Image
Image

Image

@matthiasfabry matthiasfabry added the optimization Optimizes code without fundamentally changing any functionality label Feb 11, 2025
@matthiasfabry matthiasfabry self-assigned this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Optimizes code without fundamentally changing any functionality
Projects
None yet
Development

No branches or pull requests

1 participant