Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devices: fix building of new devices (gr712rc, mcxn94x, ...) #356

Merged
merged 1 commit into from
Sep 27, 2024
Merged

devices: fix building of new devices (gr712rc, mcxn94x, ...) #356

merged 1 commit into from
Sep 27, 2024

Conversation

Darchiv
Copy link
Member

@Darchiv Darchiv commented Sep 27, 2024

This fixes building of recently added devices (from e.g. #337) which were merged before merging #315 (which did not cover these devices).

JIRA: RTOS-930

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@github-actions GitHub Actions
Copy link

Unit Test Results

7 723 tests  ±0   7 008 ✅ ±0   37m 18s ⏱️ -19s
  443 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit fc77408. ± Comparison against base commit 5a48f1f.

@Darchiv Darchiv marked this pull request as ready for review September 27, 2024 09:48
@Darchiv Darchiv merged commit 23534d2 into master Sep 27, 2024
34 checks passed
@Darchiv Darchiv deleted the Darchiv/RTOS-930 branch September 27, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalajcie nalajcie nalajcie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Darchiv @nalajcie