Make the default :info flash display "Info" instead, and add a :success flash with the old behaviour #5844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. However, I think we should keep the generated code simple and not add a new style. We should either rename :info to :success or change the style of |
|
We've done something similar on a couple projects. I think the defaults are fine as they are, but some of the documentation doesn't actually make it very clear that flash types can be whatever (at least in the liveview documentation). Maybe we start with just adding a little nice clarification here for now. |
|
@mattmatters the docs were already adjusted in response to phoenixframework/phoenix_live_view#3342, but that’s not released yet :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5795
Also use blue for the info flash, as that is what info dialogues tend to use.