bugfix(phoenix_html.js): Make IIFE idempotent by injecting a global _… #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…phx_loaded boolean flag that is set after setup. Prevents event handlers from being set multiple times in case of libraries like turbolinks which would run this code several times
|
Thanks for the PR! I am not sure but wouldn’t it be more idiomatic to use a named function? It feels like adding this to work around a limitation on Turbolinks, which is arguably the one in the wrong here, is not very clean. |
|
Closing as stale. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…phx_loaded boolean flag that is set after setup. Prevents event handlers from being set multiple times in case of libraries like turbolinks which would run this code several times.
@josevalim @chrismccord fixes #284.
After taking some time to think about the problem, I took a different approach than what I outlined in the previous discussion. I think this is a simpler and more robust solution to the problem since there is not much javascript actually being executed. Let me know what you think.