Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comments from app.js #27

Open
aegatlin opened this issue Feb 2, 2022 · 0 comments
Open

Remove comments from app.js #27

aegatlin opened this issue Feb 2, 2022 · 0 comments

Comments

@aegatlin
Copy link

aegatlin commented Feb 2, 2022

Hello, love this project and excited to see it continue <3

In assets/js/app.js line 3 is removed but not lines 1 and 2 which pertain to it:

// We import the CSS which is extracted to its own file by esbuild.
// Remove this line if you add a your own CSS build pipeline (e.g postcss).
import "../css/app.css"

I'm suggesting removing lines 1 & 2 as well because it would be confusing in the future to come across those comments having forgotten you already did "remove this line". This file augmentation code is already being tested, so a PR could add those as well.

Alternatively, you could comment out line 3 instead of deleting it. In that case, there is a grammatical error on line 2 which could be PR'd as well.

I'm happy to submit a PR for any of this when I get a chance, but also happy to have someone else do the work 😉 if it's deemed a worthy change. Thanks! :D

@aegatlin aegatlin changed the title Also remove comments from app.js Remove comments from app.js Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant