-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Typescript definitions are outdated, API needs remirroring #1536
Comments
Update #1621 in type definition too. |
@fredgalvao can we close this now? |
Nop. Having the definitions in-house made it easier, but not invalid. I'll still work on updating the interfaces/objects. |
I am facing the same issue. Can't find the clearAllNotifications function. Please suggest a solution or an alternative. Thank you. |
@kanak-infoObjects I don't have an alternative. I'm sorry to say I haven't had the time to review the type definitions since forever, I'll try to get it done soon. |
Even though |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I'll close this and open a new one to actually update all the missing parts, as this is too old by now, and has been partially done over time. |
This thread has been automatically locked. |
It's time. |
Some/most of the callbacks that have well defined parameters are not properly typed either. Also, reminder to review #2607 and missing optionality on attributes. |
Expected Behaviour
100% API and settings/options coverage on typescript
Actual Behaviour
We're lacking
clearAllNotifications
there, at the very least. Needs reviewing.Reproduce Scenario (including but not limited to)
Steps to Reproduce
See #1530.
Plugin version
Latest on each main branch (1.9.x && 2.0.x)
The text was updated successfully, but these errors were encountered: