Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery blank image issue #471

Open
httpdispatch opened this issue Nov 19, 2013 · 1 comment
Open

Gallery blank image issue #471

httpdispatch opened this issue Nov 19, 2013 · 1 comment
Labels
To be tested

Comments

@httpdispatch
Copy link
Contributor

Sometimes even if image is downloaded successfully it may not appear in the gallery showing blank black square. It may be related to image worker cancelPotentialWork logic.

Another case is if application was suspended or opened another activity, but this is by design. Need to locate and fix first case
@httpdispatch
Copy link
Contributor Author

second case may be caused by multithread loading for same file path. Need to handle this behaviours more accurate

httpdispatch added a commit to httpdispatch/mobile-android that referenced this issue Nov 20, 2013
@httpdispatch
Issue photo#471
5208ce1 
- GalleryFragment.CustomImageFetcher,
SyncImageSelectionFragment.CustomImageFileSystemFetcher, ImageFetcher,
ImageFileSystemFetcher, ImageResizer: added new missing parameter
processingState to the overridden processBitmap method
- GalleryFragment.PhotosGridOnTouchListener: added additional check to
the onScale method to do not rebuild groups if new scal factor is the
same as previous
- GalleryFragment: added mRevalidateRequired field
- GalleryFragment: overrode setImageWorkerExitTaskEarly method and added
mAdapter.notifyDataSetChanged() call when the
setImageWorkerExitTaskEarly is called with false parameter and
previously it was called with true
- GalleryFragment: added mRevalidateRequired call to the refresh method
- DiskLruCache: changed modifier for the CACHE_FILENAME_PREFIX to public
- DiskLruCache: added getCacheDir - getter for the mCacheDire method
- ImageFetcher: added processingState parameter to the processBitmap
method variations
- ImageFetcher: added processingState parameter to the downloadBitmap
which is checked during download and may interrupt process
- ImageFetcher: added temp file usage for download and then renaming it
to target cache file to avoid problems in multithreading environment
- ImageWorker: added additional debug logging to the setExitTaskEarly
method
- ImageWorker: fixed debug logging in the cancelPotentialWork method and
added bitmapWorkerTask.isCancelled() check to avoid reusage of cancelled
jobs
- ImageWorker.BitmapWorkerTask: now it implements ProcessingState
interface
- ImageWorker.BitmapWorkerTask: added additional required parameter to
the processBitmap call in the doInBackground method
- ImageWorker.BitmapWorkerTask: added isProcessingCancelled method
implementation
- ImageWorker.ProcessingState: added
- ImageFlowUtils: added debug output to the getView method
- ImageFlowUtils: added layoutParams check to the getSingleImageView
method
- AndroidManifest.xml: updated version code and name
httpdispatch added a commit to httpdispatch/mobile-android that referenced this issue Dec 6, 2013
@httpdispatch
Issue photo#471
90d540a 
- GalleryFragment.CustomImageFetcher,
SyncImageSelectionFragment.CustomImageFileSystemFetcher, ImageFetcher,
ImageFileSystemFetcher, ImageResizer: added new missing parameter
processingState to the overridden processBitmap method
- GalleryFragment.PhotosGridOnTouchListener: added additional check to
the onScale method to do not rebuild groups if new scal factor is the
same as previous
- GalleryFragment: added mRevalidateRequired field
- GalleryFragment: overrode setImageWorkerExitTaskEarly method and added
mAdapter.notifyDataSetChanged() call when the
setImageWorkerExitTaskEarly is called with false parameter and
previously it was called with true
- GalleryFragment: added mRevalidateRequired call to the refresh method
- DiskLruCache: changed modifier for the CACHE_FILENAME_PREFIX to public
- DiskLruCache: added getCacheDir - getter for the mCacheDire method
- ImageFetcher: added processingState parameter to the processBitmap
method variations
- ImageFetcher: added processingState parameter to the downloadBitmap
which is checked during download and may interrupt process
- ImageFetcher: added temp file usage for download and then renaming it
to target cache file to avoid problems in multithreading environment
- ImageWorker: added additional debug logging to the setExitTaskEarly
method
- ImageWorker: fixed debug logging in the cancelPotentialWork method and
added bitmapWorkerTask.isCancelled() check to avoid reusage of cancelled
jobs
- ImageWorker.BitmapWorkerTask: now it implements ProcessingState
interface
- ImageWorker.BitmapWorkerTask: added additional required parameter to
the processBitmap call in the doInBackground method
- ImageWorker.BitmapWorkerTask: added isProcessingCancelled method
implementation
- ImageWorker.ProcessingState: added
- ImageFlowUtils: added debug output to the getView method
- ImageFlowUtils: added layoutParams check to the getSingleImageView
method
- AndroidManifest.xml: updated version code and name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
To be tested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@httpdispatch