-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support async queryset evaluation #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good to have a apage
function, not sure if django's default paginator has it though (but it doesn't matter)
I left a comment around the last
argument potentially being broken in the async version
@bradleyoesch sorry, I missed the updates, I'll try to review and merge in next few days |
@bradleyoesch I pushed a couple of commits to fix the tests 😊 I think I want to update the CI to run tests on different python version with different django versions, but I'm fine with merging this now, but can you double check my changes? |
Thank you! Yeah those look good to me overall! Left one comment on |
@patrick91 is this all good to go? Anything else I can do to get this merged? |
@bradleyoesch just the ping is enough! thanks 😊 |
Thanks for the contribution @bradleyoesch. And thanks for reviewing @patrick91 |
Thanks yall! |
Closes #50
Was switching our codebase over to async so we could use dataloaders and realized this library didn't support async querysets
I cannot claim to be very knowledgeable about async python but this is what I did locally 🤷