Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support async queryset evaluation #49

Merged
merged 11 commits into from
Jul 1, 2024

Conversation

bradleyoesch
Copy link
Contributor

@bradleyoesch bradleyoesch commented May 16, 2024

Closes #50

Was switching our codebase over to async so we could use dataloaders and realized this library didn't support async querysets

I cannot claim to be very knowledgeable about async python but this is what I did locally 🤷

Copy link
Collaborator

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good to have a apage function, not sure if django's default paginator has it though (but it doesn't matter)

I left a comment around the last argument potentially being broken in the async version

cursor_pagination.py Show resolved Hide resolved
tests/tests.py Show resolved Hide resolved
@patrick91
Copy link
Collaborator

@bradleyoesch sorry, I missed the updates, I'll try to review and merge in next few days

@patrick91
Copy link
Collaborator

@bradleyoesch I pushed a couple of commits to fix the tests 😊

I think I want to update the CI to run tests on different python version with different django versions, but I'm fine with merging this now, but can you double check my changes?

cursor_pagination.py Outdated Show resolved Hide resolved
@bradleyoesch
Copy link
Contributor Author

@bradleyoesch I pushed a couple of commits to fix the tests 😊

I think I want to update the CI to run tests on different python version with different django versions, but I'm fine with merging this now, but can you double check my changes?

Thank you! Yeah those look good to me overall! Left one comment on acount()

@bradleyoesch
Copy link
Contributor Author

@patrick91 is this all good to go? Anything else I can do to get this merged?

@patrick91
Copy link
Collaborator

@bradleyoesch just the ping is enough! thanks 😊

@patrick91 patrick91 merged commit 8ea96d4 into photocrowd:master Jul 1, 2024
4 checks passed
@patrick91
Copy link
Collaborator

@bradleyoesch released: https://pypi.org/project/django-cursor-pagination/0.3.0/

@thommor
Copy link
Contributor

thommor commented Jul 1, 2024

Thanks for the contribution @bradleyoesch.

And thanks for reviewing @patrick91

@bradleyoesch
Copy link
Contributor Author

Thanks yall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support async queryset evaluation
4 participants