remove useless empty constructorn change new param node from scalar t…

…o boolean
php-etl · May 27, 2024 · 320bdd5 · 320bdd5
1 parent e14c1d1
commit 320bdd5
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 17 deletions.
diff --git a/src/Builder/Capacity/Extractor/Get.php b/src/Builder/Capacity/Extractor/Get.php
@@ -13,10 +13,6 @@ final class Get implements Builder
     private Node\Expr|Node\Identifier|null $endpoint = null;
     private ?Node\Expr $identifier = null;
 
-    public function __construct()
-    {
-    }
-
     public function withEndpoint(Node\Expr|Node\Identifier $endpoint): self
     {
         $this->endpoint = $endpoint;

diff --git a/src/Builder/Capacity/Extractor/ListPerPage.php b/src/Builder/Capacity/Extractor/ListPerPage.php
@@ -14,10 +14,6 @@ final class ListPerPage implements Builder
     private ?Node\Expr $search = null;
     private ?Node\Expr $code = null;
 
-    public function __construct()
-    {
-    }
-
     public function withEndpoint(Node\Expr|Node\Identifier $endpoint): self
     {
         $this->endpoint = $endpoint;

diff --git a/src/Builder/Capacity/Lookup/Get.php b/src/Builder/Capacity/Lookup/Get.php
@@ -15,10 +15,6 @@ final class Get implements Builder
     private ?Node\Expr $code = null;
     private ?string $type = '';
 
-    public function __construct()
-    {
-    }
-
     public function withEndpoint(Node\Expr|Node\Identifier $endpoint): self
     {
         $this->endpoint = $endpoint;

diff --git a/src/Builder/Capacity/Lookup/ListPerPage.php b/src/Builder/Capacity/Lookup/ListPerPage.php
@@ -14,10 +14,6 @@ final class ListPerPage implements Builder
     private ?Node\Expr $search = null;
     private ?Node\Expr $code = null;
 
-    public function __construct()
-    {
-    }
-
     public function withEndpoint(Node\Expr|Node\Identifier $endpoint): self
     {
         $this->endpoint = $endpoint;

diff --git a/src/Configuration/Extractor.php b/src/Configuration/Extractor.php
@@ -238,7 +238,8 @@ public function getConfigTreeBuilder(): Config\Definition\Builder\TreeBuilder
                         ->then(asExpression())
                     ->end()
                 ->end()
-                ->scalarNode('with_enriched_attributes')
+                ->booleanNode('with_enriched_attributes')
+                    ->defaultFalse()
                     ->validate()
                         ->ifTrue(isExpression())
                         ->then(asExpression())