Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new parameter for endpoint category #60

Merged
merged 9 commits into from
May 28, 2024

Conversation

JoMessina
Copy link
Contributor

@JoMessina JoMessina commented May 23, 2024

Add with_enriched_attributes parameter to pull template's attributes on enriched categories

Issues : #61

@JoMessina JoMessina requested a review from sebprt May 23, 2024 14:14
@JoMessina JoMessina force-pushed the feature/add-category-enriched-attributes-parameter branch from 820fec7 to 4b7f440 Compare May 23, 2024 14:35
@JoMessina JoMessina force-pushed the feature/add-category-enriched-attributes-parameter branch from b588f7e to 772bfb6 Compare May 23, 2024 14:39
@JoMessina JoMessina added the GTM Good to merge label May 23, 2024
@JoMessina JoMessina force-pushed the feature/add-category-enriched-attributes-parameter branch 4 times, most recently from b24929c to 6d0d7cd Compare May 23, 2024 15:13
@JoMessina JoMessina force-pushed the feature/add-category-enriched-attributes-parameter branch from 6d0d7cd to 3a269ab Compare May 23, 2024 15:16
@JoMessina JoMessina requested a review from gplanchat May 24, 2024 08:13
sebprt
sebprt previously requested changes May 24, 2024
src/Configuration/Extractor.php Outdated Show resolved Hide resolved
src/Builder/Capacity/Lookup/ListPerPage.php Outdated Show resolved Hide resolved
src/Builder/Capacity/Lookup/Get.php Outdated Show resolved Hide resolved
src/Builder/Capacity/Lookup/Get.php Outdated Show resolved Hide resolved
src/Builder/Capacity/Lookup/ListPerPage.php Outdated Show resolved Hide resolved
src/Builder/Capacity/Extractor/ListPerPage.php Outdated Show resolved Hide resolved
src/Builder/Capacity/Extractor/ListPerPage.php Outdated Show resolved Hide resolved
src/Builder/Capacity/Extractor/Get.php Outdated Show resolved Hide resolved
src/Builder/Capacity/Extractor/Get.php Outdated Show resolved Hide resolved
src/Builder/Capacity/Extractor/All.php Outdated Show resolved Hide resolved
@JoMessina JoMessina requested a review from sebprt May 27, 2024 07:50
@JoMessina JoMessina force-pushed the feature/add-category-enriched-attributes-parameter branch 2 times, most recently from de36c81 to f4e47df Compare May 27, 2024 09:59
@JoMessina JoMessina force-pushed the feature/add-category-enriched-attributes-parameter branch from f4e47df to 3119b33 Compare May 27, 2024 10:05
@JoMessina JoMessina force-pushed the feature/add-category-enriched-attributes-parameter branch from 89dedfc to aaf8ad0 Compare May 27, 2024 12:30
@gplanchat gplanchat dismissed sebprt’s stale review May 28, 2024 14:39

Les retours sont tous traités quand c'est nécessaire

@gplanchat gplanchat merged commit 8bd9897 into main May 28, 2024
5 of 9 checks passed
@gplanchat gplanchat deleted the feature/add-category-enriched-attributes-parameter branch May 28, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GTM Good to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants