Apply suggestions from code review

php-etl · Feb 1, 2024 · 312d50e · 312d50e
1 parent f15caa9
commit 312d50e
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/src/PHP/ComposerConfigGlobal.php b/src/PHP/ComposerConfigGlobal.php
@@ -10,18 +10,15 @@
 {
     public function __construct(
         private string $host,
-        private string $token,
+        private string $tokenArgument,
     ) {
     }
 
     public function __toString(): string
     {
-        return (string) new Dockerfile\Run(sprintf(
-            <<<'RUN'
-                composer config --global %s %s
-                RUN,
-            $this->host,
-            $this->token,
-        ));
+        return (string) new Dockerfile\Run(<<<"RUN"
+            composer config --global {$this->host} \${{$this->tokenArgument}}
+            RUN,
+        );
     }
 }