move api_type in extractor/loader config, choose the right builder in…

… extractor/loader builders, edit service to set all these new apiType variables
php-etl · Oct 25, 2023 · a9bfc43 · a9bfc43
1 parent 642db8a
commit a9bfc43
Show file tree

Hide file tree

Showing 9 changed files with 106 additions and 38 deletions.
diff --git a/src/Builder/Client.php b/src/Builder/Client.php
@@ -4,6 +4,8 @@
 
 namespace Kiboko\Plugin\Sylius\Builder;
 
+use Diglin\Sylius\ApiClient\SyliusAdminClientBuilder;
+use Diglin\Sylius\ApiClient\SyliusShopClientBuilder;
 use Kiboko\Plugin\Sylius\MissingAuthenticationMethodException;
 use PhpParser\Builder;
 use PhpParser\Node;
@@ -18,8 +20,13 @@ final class Client implements Builder
     private ?Node\Expr $httpRequestFactory = null;
     private ?Node\Expr $httpStreamFactory = null;
     private ?Node\Expr $fileSystem = null;
+    private string $apiType = '';
 
-    public function __construct(private readonly Node\Expr $baseUrl, private readonly Node\Expr $clientId, private readonly Node\Expr $secret, private readonly null|Node\Expr $apiType)
+    public const API_ADMIN_KEY = 'admin';
+    public const API_SHOP_KEY = 'shop';
+    public const API_LEGACY_KEY = 'legacy';
+
+    public function __construct(private readonly Node\Expr $baseUrl, private readonly Node\Expr $clientId, private readonly Node\Expr $secret)
     {
     }
 
@@ -31,6 +38,13 @@ public function withToken(Node\Expr $token, Node\Expr $refreshToken): self
         return $this;
     }
 
+    public function withApiType(string $apiType): self
+    {
+        $this->apiType = $apiType;
+
+        return $this;
+    }
+
     public function withPassword(Node\Expr $username, Node\Expr $password): self
     {
         $this->username = $username;
@@ -121,10 +135,9 @@ public function getNode(): Node\Expr\MethodCall
     private function getClientBuilderNode(): Node\Expr\MethodCall
     {
         $className = match ($this->apiType) {
-            'admin' => \Diglin\Sylius\ApiClient\SyliusAdminClientBuilder::class,
-            'store' => \Diglin\Sylius\ApiClient\SyliusShopClientBuilder::class,
-            'legacy' => 'Diglin\\Sylius\\ApiClient\\SyliusClientBuilder',
-            default => 'Diglin\\Sylius\\ApiClient\\SyliusClientBuilder',
+            self::API_ADMIN_KEY => SyliusAdminClientBuilder::class,
+            self::API_SHOP_KEY => SyliusShopClientBuilder::class,
+            self::API_LEGACY_KEY => 'Diglin\\Sylius\\ApiClient\\SyliusClientBuilder'
         };
 
         return new Node\Expr\MethodCall(

diff --git a/src/Builder/Extractor.php b/src/Builder/Extractor.php
@@ -12,6 +12,7 @@ final class Extractor implements StepBuilderInterface
 {
     private ?Node\Expr $logger = null;
     private ?Node\Expr $client = null;
+    private string $apiType;
 
     public function __construct(private readonly Builder $capacity)
     {
@@ -24,6 +25,13 @@ public function withClient(Node\Expr $client): self
         return $this;
     }
 
+    public function withApiType(string $apiType): self
+    {
+        $this->apiType = $apiType;
+
+        return $this;
+    }
+
     public function withLogger(Node\Expr $logger): self
     {
         $this->logger = $logger;
@@ -55,18 +63,7 @@ class: new Node\Stmt\Class_(
                             name: new Node\Identifier(name: '__construct'),
                             subNodes: [
                                 'flags' => Node\Stmt\Class_::MODIFIER_PUBLIC,
-                                'params' => [
-                                    new Node\Param(
-                                        var: new Node\Expr\Variable('client'),
-                                        type: new Node\Name\FullyQualified(name: \Diglin\Sylius\ApiClient\SyliusLegacyClientInterface::class),
-                                        flags: Node\Stmt\Class_::MODIFIER_PUBLIC,
-                                    ),
-                                    new Node\Param(
-                                        var: new Node\Expr\Variable('logger'),
-                                        type: new Node\Name\FullyQualified(name: \Psr\Log\LoggerInterface::class),
-                                        flags: Node\Stmt\Class_::MODIFIER_PUBLIC,
-                                    ),
-                                ],
+                                'params' => $this->getParamsNode(),
                             ],
                         ),
                         new Node\Stmt\ClassMethod(
@@ -133,4 +130,26 @@ class: new Node\Stmt\Class_(
             ],
         );
     }
+
+    public function getParamsNode(): array
+    {
+
+        $className = match ($this->apiType) {
+            Client::API_ADMIN_KEY => \Diglin\Sylius\ApiClient\SyliusAdminClientInterface::class,
+            Client::API_LEGACY_KEY => \Diglin\Sylius\ApiClient\SyliusLegacyClientInterface::class,
+            Client::API_SHOP_KEY => \Diglin\Sylius\ApiClient\SyliusShopClientInterface::class,
+        };
+        return [
+            new Node\Param(
+                var: new Node\Expr\Variable('client'),
+                type: new Node\Name\FullyQualified(name: $className),
+                flags: Node\Stmt\Class_::MODIFIER_PRIVATE,
+            ),
+            new Node\Param(
+                var: new Node\Expr\Variable('logger'),
+                type: new Node\Name\FullyQualified(name: \Psr\Log\LoggerInterface::class),
+                flags: Node\Stmt\Class_::MODIFIER_PRIVATE,
+            ),
+        ];
+    }
 }
diff --git a/src/Builder/Loader.php b/src/Builder/Loader.php
@@ -12,6 +12,7 @@ final class Loader implements StepBuilderInterface
 {
     private ?Node\Expr $logger = null;
     private ?Node\Expr $client = null;
+    private string $apiType;
 
     public function __construct(private readonly Builder $capacity)
     {
@@ -24,6 +25,13 @@ public function withClient(Node\Expr $client): self
         return $this;
     }
 
+    public function withApiType(string $apiType): self
+    {
+        $this->apiType = $apiType;
+
+        return $this;
+    }
+
     public function withLogger(Node\Expr $logger): self
     {
         $this->logger = $logger;
@@ -55,18 +63,7 @@ class: new Node\Stmt\Class_(
                             name: new Node\Identifier(name: '__construct'),
                             subNodes: [
                                 'flags' => Node\Stmt\Class_::MODIFIER_PUBLIC,
-                                'params' => [
-                                    new Node\Param(
-                                        var: new Node\Expr\Variable('client'),
-                                        type: new Node\Name\FullyQualified(name: \Diglin\Sylius\ApiClient\SyliusLegacyClientInterface::class),
-                                        flags: Node\Stmt\Class_::MODIFIER_PRIVATE,
-                                    ),
-                                    new Node\Param(
-                                        var: new Node\Expr\Variable('logger'),
-                                        type: new Node\Name\FullyQualified(name: \Psr\Log\LoggerInterface::class),
-                                        flags: Node\Stmt\Class_::MODIFIER_PRIVATE,
-                                    ),
-                                ],
+                                'params' => $this->getParamsNode(),
                             ],
                         ),
                         new Node\Stmt\ClassMethod(
@@ -139,4 +136,26 @@ class: new Node\Stmt\Class_(
             ],
         );
     }
+
+    public function getParamsNode(): array
+    {
+
+        $className = match ($this->apiType) {
+            Client::API_ADMIN_KEY => \Diglin\Sylius\ApiClient\SyliusAdminClientInterface::class,
+            Client::API_LEGACY_KEY => \Diglin\Sylius\ApiClient\SyliusLegacyClientInterface::class,
+            Client::API_SHOP_KEY => \Diglin\Sylius\ApiClient\SyliusShopClientInterface::class,
+        };
+        return [
+            new Node\Param(
+                var: new Node\Expr\Variable('client'),
+                type: new Node\Name\FullyQualified(name: $className),
+                flags: Node\Stmt\Class_::MODIFIER_PRIVATE,
+            ),
+            new Node\Param(
+                var: new Node\Expr\Variable('logger'),
+                type: new Node\Name\FullyQualified(name: \Psr\Log\LoggerInterface::class),
+                flags: Node\Stmt\Class_::MODIFIER_PRIVATE,
+            ),
+        ];
+    }
 }
diff --git a/src/Configuration.php b/src/Configuration.php
@@ -6,6 +6,8 @@
 
 use Kiboko\Contract\Configurator\PluginConfigurationInterface;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
+use function Kiboko\Component\SatelliteToolbox\Configuration\asExpression;
+use function Kiboko\Component\SatelliteToolbox\Configuration\isExpression;
 
 final class Configuration implements PluginConfigurationInterface
 {
@@ -27,6 +29,14 @@ public function getConfigTreeBuilder(): TreeBuilder
                 ->arrayNode('expression_language')
                     ->scalarPrototype()->end()
                 ->end()
+                ->scalarNode('api_type')
+                    ->isRequired()
+                    ->cannotBeEmpty()
+                    ->validate()
+                        ->ifTrue(isExpression())
+                        ->then(asExpression())
+                    ->end()
+                ->end()
                 ->append(node: $extractor->getConfigTreeBuilder()->getRootNode())
                 ->append(node: $loader->getConfigTreeBuilder()->getRootNode())
                 ->append(node: $client->getConfigTreeBuilder()->getRootNode())

diff --git a/src/Configuration/Client.php b/src/Configuration/Client.php
@@ -67,14 +67,6 @@ public function getConfigTreeBuilder(): \Symfony\Component\Config\Definition\Bui
                         ->end()
                     ->end()
                 ->end()
-                ->scalarNode('api_type')
-                    ->isRequired()
-                    ->cannotBeEmpty()
-                    ->validate()
-                        ->ifTrue(isExpression())
-                        ->then(asExpression())
-                    ->end()
-                ->end()
                 ->scalarNode('api_url')
                     ->isRequired()
                     ->cannotBeEmpty()

diff --git a/src/Configuration/Extractor.php b/src/Configuration/Extractor.php
@@ -165,6 +165,10 @@ public function getConfigTreeBuilder(): \Symfony\Component\Config\Definition\Bui
                 })
             ->end()
             ->children()
+                ->scalarNode('api_type')
+                    ->isRequired()
+                    ->cannotBeEmpty()
+                ->end()
                 ->scalarNode('type')
                     ->isRequired()
                     ->validate()

diff --git a/src/Configuration/Loader.php b/src/Configuration/Loader.php
@@ -118,6 +118,10 @@ public function getConfigTreeBuilder(): \Symfony\Component\Config\Definition\Bui
                 })
             ->end()
             ->children()
+                ->scalarNode('api_type')
+                    ->isRequired()
+                    ->cannotBeEmpty()
+                ->end()
                 ->scalarNode('type')
                     ->isRequired()
                     ->validate()

diff --git a/src/Factory/Client.php b/src/Factory/Client.php
@@ -74,7 +74,6 @@ public function compile(array $config): Repository\Client
                 compileValueWhenExpression($this->interpreter, $config['api_url']),
                 compileValueWhenExpression($this->interpreter, $config['client_id']),
                 compileValueWhenExpression($this->interpreter, $config['secret']),
-                compileValueWhenExpression($this->interpreter, $config['api_type']),
             );
 
             if (isset($config['context'])) {
@@ -92,6 +91,10 @@ public function compile(array $config): Repository\Client
                 }
             }
 
+            if (isset($config['api_type'])) {
+                $clientBuilder->withApiType($config['api_type']);
+            }
+
             if (isset($config['password'])) {
                 $clientBuilder->withPassword(
                     compileValueWhenExpression($this->interpreter, $config['username']),

diff --git a/src/Service.php b/src/Service.php
@@ -89,9 +89,11 @@ public function compile(array $config): Factory\Repository\Extractor|Factory\Rep
                 $extractor = $extractorFactory->compile($config['extractor']);
                 $extractorBuilder = $extractor->getBuilder();
 
+                $clientFactory->withApiType($config['extractor']['api_type']);
                 $client = $clientFactory->compile($config['client']);
 
                 $extractorBuilder->withClient($client->getBuilder()->getNode());
+                $extractorBuilder->withApiType($config['extractor']['api_type']);
 
                 $extractor->merge($client);
 
@@ -103,9 +105,11 @@ public function compile(array $config): Factory\Repository\Extractor|Factory\Rep
                 $loader = $loaderFactory->compile($config['loader']);
                 $loaderBuilder = $loader->getBuilder();
 
+                $clientFactory->withApiType($config['loader']['api_type']);
                 $client = $clientFactory->compile($config['client']);
 
                 $loaderBuilder->withClient($client->getBuilder()->getNode());
+                $loaderBuilder->withApiType($config['loader']['api_type']);
 
                 $loader->merge($client);