Update Imagick method synopses (#4118) #4120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The argument names where wrong for a lot of methods.
stefanfisk
force-pushed
the
issue/4118-imagick-arg-names
branch
from
aa1c9ac to
3580683
Compare
|
I also had to do some manual cleanup of trailing white space. |
|
Could you maybe do this class by class in different PRs? As the stub changes currently also impacts how Xincludes are down in the class synopsis, so you probably need to also run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument names were wrong for a lot of methods.
I'm not entirely sure that I know what I'm doing, but the steps I took were:
php/doc-en,php/doc-base,php/php-srcandImagick/imagickImagick::newImage()like in Fix nullable in Imagick.stub.php Imagick/imagick#674./php-src/build/gen_stub.php --replace-methodsynopses ./imagick/*.stub.php ./doc-en/reference/imagick/Resolves #4118.