From a6276c19e7d25223b1f21824ccc85fb4f9ef4e9a Mon Sep 17 00:00:00 2001
From: Alexandre Daubois <alex.daubois@gmail.com>
Date: Tue, 3 Dec 2024 19:12:35 +0100
Subject: [PATCH] [PHP 8.4] Add `ext-date` constant types

---
 reference/datetime/dateperiod.xml        | 16 ++++-
 reference/datetime/datetime.xml          |  6 ++
 reference/datetime/datetimeimmutable.xml |  6 ++
 reference/datetime/datetimeinterface.xml | 74 +++++++++++++++----
 reference/datetime/datetimezone.xml      | 92 ++++++++++++++++++++----
 5 files changed, 163 insertions(+), 31 deletions(-)

diff --git a/reference/datetime/dateperiod.xml b/reference/datetime/dateperiod.xml
index 73631b178971..960e46a3be57 100644
--- a/reference/datetime/dateperiod.xml
+++ b/reference/datetime/dateperiod.xml
@@ -109,14 +109,20 @@
    &reftitle.constants;
    <variablelist>
     <varlistentry xml:id="dateperiod.constants.exclude-start-date">
-     <term><constant>DatePeriod::EXCLUDE_START_DATE</constant></term>
+     <term>
+      <constant>DatePeriod::EXCLUDE_START_DATE</constant>
+      <type>int</type>
+     </term>
      <listitem>
       <para>Exclude start date, used in <function>DatePeriod::__construct</function>.</para>
      </listitem>
     </varlistentry>
 
     <varlistentry xml:id="dateperiod.constants.include-end-date">
-     <term><constant>DatePeriod::INCLUDE_END_DATE</constant></term>
+     <term>
+      <constant>DatePeriod::INCLUDE_END_DATE</constant>
+      <type>int</type>
+     </term>
      <listitem>
       <para>Include end date, used in <function>DatePeriod::__construct</function>.</para>
      </listitem>
@@ -257,6 +263,12 @@ echo $period->recurrences, "\n";
       </row>
      </thead>
      <tbody>
+      <row>
+       <entry>8.4.0</entry>
+       <entry>
+        The class constants are now typed.
+       </entry>
+      </row>
       <row>
        <entry>8.2.0</entry>
        <entry>
diff --git a/reference/datetime/datetime.xml b/reference/datetime/datetime.xml
index 6a56f5718cc9..04227c08a472 100644
--- a/reference/datetime/datetime.xml
+++ b/reference/datetime/datetime.xml
@@ -77,6 +77,12 @@
       </row>
      </thead>
      <tbody>
+      <row>
+       <entry>8.4.0</entry>
+       <entry>
+        The class constants are now typed.
+       </entry>
+      </row>
       <row>
        <entry>7.2.0</entry>
        <entry>
diff --git a/reference/datetime/datetimeimmutable.xml b/reference/datetime/datetimeimmutable.xml
index 4cbc423683e7..e8886dde666f 100644
--- a/reference/datetime/datetimeimmutable.xml
+++ b/reference/datetime/datetimeimmutable.xml
@@ -67,6 +67,12 @@
       </row>
      </thead>
      <tbody>
+      <row>
+       <entry>8.4.0</entry>
+       <entry>
+        The class constants are now typed.
+       </entry>
+      </row>
       <row>
        <entry>7.1.0</entry>
        <entry>
diff --git a/reference/datetime/datetimeinterface.xml b/reference/datetime/datetimeinterface.xml
index 8b5178fc6b15..54fc595c3d49 100644
--- a/reference/datetime/datetimeinterface.xml
+++ b/reference/datetime/datetimeinterface.xml
@@ -151,7 +151,10 @@
    &reftitle.constants;
    <variablelist>
     <varlistentry xml:id="datetimeinterface.constants.atom">
-     <term><constant>DateTimeInterface::ATOM</constant></term>
+     <term>
+      <constant>DateTimeInterface::ATOM</constant>
+      <type>string</type>
+     </term>
      <term><constant>DATE_ATOM</constant></term>
      <listitem>
       <simpara>
@@ -161,7 +164,10 @@
     </varlistentry>
 
     <varlistentry xml:id="datetimeinterface.constants.cookie">
-     <term><constant>DateTimeInterface::COOKIE</constant></term>
+     <term>
+      <constant>DateTimeInterface::COOKIE</constant>
+      <type>string</type>
+     </term>
      <term><constant>DATE_COOKIE</constant></term>
      <listitem>
       <simpara>
@@ -171,7 +177,10 @@
     </varlistentry>
 
     <varlistentry xml:id="datetimeinterface.constants.iso8601">
-     <term><constant>DateTimeInterface::ISO8601</constant></term>
+     <term>
+      <constant>DateTimeInterface::ISO8601</constant>
+      <type>string</type>
+     </term>
      <term><constant>DATE_ISO8601</constant></term>
      <listitem>
       <simpara>
@@ -190,7 +199,10 @@
     </varlistentry>
 
     <varlistentry xml:id="datetimeinterface.constants.iso8601-expanded">
-     <term><constant>DateTimeInterface::ISO8601_EXPANDED</constant></term>
+     <term>
+      <constant>DateTimeInterface::ISO8601_EXPANDED</constant>
+      <type>string</type>
+     </term>
      <term><constant>DATE_ISO8601_EXPANDED</constant></term>
      <listitem>
       <simpara>
@@ -208,7 +220,10 @@
     </varlistentry>
 
     <varlistentry xml:id="datetimeinterface.constants.rfc822">
-     <term><constant>DateTimeInterface::RFC822</constant></term>
+     <term>
+      <constant>DateTimeInterface::RFC822</constant>
+      <type>string</type>
+     </term>
      <term><constant>DATE_RFC822</constant></term>
      <listitem>
       <simpara>
@@ -218,7 +233,10 @@
     </varlistentry>
 
     <varlistentry xml:id="datetimeinterface.constants.rfc850">
-     <term><constant>DateTimeInterface::RFC850</constant></term>
+     <term>
+      <constant>DateTimeInterface::RFC850</constant>
+      <type>string</type>
+     </term>
      <term><constant>DATE_RFC850</constant></term>
      <listitem>
       <simpara>
@@ -228,7 +246,10 @@
     </varlistentry>
 
     <varlistentry xml:id="datetimeinterface.constants.rfc1036">
-     <term><constant>DateTimeInterface::RFC1036</constant></term>
+     <term>
+      <constant>DateTimeInterface::RFC1036</constant>
+      <type>string</type>
+     </term>
      <term><constant>DATE_RFC1036</constant></term>
      <listitem>
       <simpara>
@@ -238,7 +259,10 @@
     </varlistentry>
 
     <varlistentry xml:id="datetimeinterface.constants.rfc1123">
-     <term><constant>DateTimeInterface::RFC1123</constant></term>
+     <term>
+      <constant>DateTimeInterface::RFC1123</constant>
+      <type>string</type>
+     </term>
      <term><constant>DATE_RFC1123</constant></term>
      <listitem>
       <simpara>
@@ -248,7 +272,10 @@
     </varlistentry>
 
     <varlistentry xml:id="datetimeinterface.constants.rfc7231">
-      <term><constant>DateTimeInterface::RFC7231</constant></term>
+      <term>
+       <constant>DateTimeInterface::RFC7231</constant>
+       <type>string</type>
+      </term>
       <term><constant>DATE_RFC7231</constant></term>
       <listitem>
        <simpara>
@@ -258,7 +285,10 @@
     </varlistentry>
 
     <varlistentry xml:id="datetimeinterface.constants.rfc2822">
-     <term><constant>DateTimeInterface::RFC2822</constant></term>
+     <term>
+      <constant>DateTimeInterface::RFC2822</constant>
+      <type>string</type>
+     </term>
      <term><constant>DATE_RFC2822</constant></term>
      <listitem>
       <simpara>
@@ -268,7 +298,10 @@
     </varlistentry>
 
     <varlistentry xml:id="datetimeinterface.constants.rfc3339">
-     <term><constant>DateTimeInterface::RFC3339</constant></term>
+     <term>
+      <constant>DateTimeInterface::RFC3339</constant>
+      <type>string</type>
+     </term>
      <term><constant>DATE_RFC3339</constant></term>
      <listitem>
       <simpara>
@@ -278,7 +311,10 @@
     </varlistentry>
 
     <varlistentry xml:id="datetimeinterface.constants.rfc3339-extended">
-     <term><constant>DateTimeInterface::RFC3339_EXTENDED</constant></term>
+     <term>
+      <constant>DateTimeInterface::RFC3339_EXTENDED</constant>
+      <type>string</type>
+     </term>
      <term><constant>DATE_RFC3339_EXTENDED</constant></term>
      <listitem>
       <simpara>
@@ -288,7 +324,10 @@
     </varlistentry>
 
     <varlistentry xml:id="datetimeinterface.constants.rss">
-     <term><constant>DateTimeInterface::RSS</constant></term>
+     <term>
+      <constant>DateTimeInterface::RSS</constant>
+      <type>string</type>
+     </term>
      <term><constant>DATE_RSS</constant></term>
      <listitem>
       <simpara>
@@ -298,7 +337,10 @@
     </varlistentry>
 
     <varlistentry xml:id="datetimeinterface.constants.w3c">
-     <term><constant>DateTimeInterface::W3C</constant></term>
+     <term>
+      <constant>DateTimeInterface::W3C</constant>
+      <type>string</type>
+     </term>
      <term><constant>DATE_W3C</constant></term>
      <listitem>
       <simpara>
@@ -323,6 +365,10 @@
       </row>
      </thead>
      <tbody>
+      <row>
+       <entry>8.4.0</entry>
+       <entry>The class constants are now typed.</entry>
+      </row>
       <row>
        <entry>8.2.0</entry>
        <entry>
diff --git a/reference/datetime/datetimezone.xml b/reference/datetime/datetimezone.xml
index 9b5b5c957d2e..5fbde1415d0f 100644
--- a/reference/datetime/datetimezone.xml
+++ b/reference/datetime/datetimezone.xml
@@ -128,98 +128,140 @@
    &reftitle.constants;
    <variablelist>
     <varlistentry xml:id="datetimezone.constants.africa">
-     <term><constant>DateTimeZone::AFRICA</constant></term>
+     <term>
+      <constant>DateTimeZone::AFRICA</constant>
+      <type>int</type>
+     </term>
      <listitem>
       <para>Africa time zones.</para>
      </listitem>
     </varlistentry>
 
     <varlistentry xml:id="datetimezone.constants.america">
-     <term><constant>DateTimeZone::AMERICA</constant></term>
+     <term>
+      <constant>DateTimeZone::AMERICA</constant>
+      <type>int</type>
+     </term>
      <listitem>
       <para>America time zones.</para>
      </listitem>
     </varlistentry>
 
     <varlistentry xml:id="datetimezone.constants.antarctica">
-     <term><constant>DateTimeZone::ANTARCTICA</constant></term>
+     <term>
+      <constant>DateTimeZone::ANTARCTICA</constant>
+      <type>int</type>
+     </term>
      <listitem>
       <para>Antarctica time zones.</para>
      </listitem>
     </varlistentry>
 
     <varlistentry xml:id="datetimezone.constants.arctic">
-     <term><constant>DateTimeZone::ARCTIC</constant></term>
+     <term>
+      <constant>DateTimeZone::ARCTIC</constant>
+      <type>int</type>
+     </term>
      <listitem>
       <para>Arctic time zones.</para>
      </listitem>
     </varlistentry>
 
     <varlistentry xml:id="datetimezone.constants.asia">
-     <term><constant>DateTimeZone::ASIA</constant></term>
+     <term>
+      <constant>DateTimeZone::ASIA</constant>
+      <type>int</type>
+     </term>
      <listitem>
       <para>Asia time zones.</para>
      </listitem>
     </varlistentry>
 
     <varlistentry xml:id="datetimezone.constants.atlantic">
-     <term><constant>DateTimeZone::ATLANTIC</constant></term>
+     <term>
+      <constant>DateTimeZone::ATLANTIC</constant>
+      <type>int</type>
+     </term>
      <listitem>
       <para>Atlantic time zones.</para>
      </listitem>
     </varlistentry>
 
     <varlistentry xml:id="datetimezone.constants.australia">
-     <term><constant>DateTimeZone::AUSTRALIA</constant></term>
+     <term>
+      <constant>DateTimeZone::AUSTRALIA</constant>
+      <type>int</type>
+     </term>
      <listitem>
       <para>Australia time zones.</para>
      </listitem>
     </varlistentry>
 
     <varlistentry xml:id="datetimezone.constants.europe">
-     <term><constant>DateTimeZone::EUROPE</constant></term>
+     <term>
+      <constant>DateTimeZone::EUROPE</constant>
+      <type>int</type>
+     </term>
      <listitem>
       <para>Europe time zones.</para>
      </listitem>
     </varlistentry>
 
     <varlistentry xml:id="datetimezone.constants.indian">
-     <term><constant>DateTimeZone::INDIAN</constant></term>
+     <term>
+      <constant>DateTimeZone::INDIAN</constant>
+      <type>int</type>
+     </term>
      <listitem>
       <para>Indian time zones.</para>
      </listitem>
     </varlistentry>
 
     <varlistentry xml:id="datetimezone.constants.pacific">
-     <term><constant>DateTimeZone::PACIFIC</constant></term>
+     <term>
+      <constant>DateTimeZone::PACIFIC</constant>
+      <type>int</type>
+     </term>
      <listitem>
       <para>Pacific time zones.</para>
      </listitem>
     </varlistentry>
 
     <varlistentry xml:id="datetimezone.constants.utc">
-     <term><constant>DateTimeZone::UTC</constant></term>
+     <term>
+      <constant>DateTimeZone::UTC</constant>
+      <type>int</type>
+     </term>
      <listitem>
       <para>UTC time zones.</para>
      </listitem>
     </varlistentry>
 
     <varlistentry xml:id="datetimezone.constants.all">
-     <term><constant>DateTimeZone::ALL</constant></term>
+     <term>
+      <constant>DateTimeZone::ALL</constant>
+      <type>int</type>
+     </term>
      <listitem>
       <para>All time zones.</para>
      </listitem>
     </varlistentry>
 
     <varlistentry xml:id="datetimezone.constants.all-with-bc">
-     <term><constant>DateTimeZone::ALL_WITH_BC</constant></term>
+     <term>
+      <constant>DateTimeZone::ALL_WITH_BC</constant>
+      <type>int</type>
+     </term>
      <listitem>
       <para>All time zones including backwards compatible.</para>
      </listitem>
     </varlistentry>
 
     <varlistentry xml:id="datetimezone.constants.per-country">
-     <term><constant>DateTimeZone::PER_COUNTRY</constant></term>
+     <term>
+      <constant>DateTimeZone::PER_COUNTRY</constant>
+      <type>int</type>
+     </term>
      <listitem>
       <para>Time zones per country.</para>
      </listitem>
@@ -228,7 +270,27 @@
    </variablelist>
   </section>
 <!-- }}} -->
-
+  <section role="changelog" xml:id="datetimezone.changelog">
+   &reftitle.changelog;
+   <informaltable>
+    <tgroup cols="2">
+     <thead>
+      <row>
+       <entry>&Version;</entry>
+       <entry>&Description;</entry>
+      </row>
+     </thead>
+     <tbody>
+      <row>
+       <entry>8.4.0</entry>
+       <entry>
+        The class constants are now typed.
+       </entry>
+      </row>
+     </tbody>
+    </tgroup>
+   </informaltable>
+  </section>
 
  </partintro>