-
Notifications
You must be signed in to change notification settings - Fork 39
/
README.SUBMITTING_CONTRIBUTIONS
50 lines (36 loc) · 2.2 KB
/
README.SUBMITTING_CONTRIBUTIONS
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
================================================================================
Submitting contributions
================================================================================
A lot of time has been put into designing, implementing and documenting this extension.
A lot of work has also been put into ensuring that users of the extension
experience very minimal defects during usage.
New ideas, corrections, bug fixes, feature improvements are always welcome.
However, you must discuss any changes you are about to make to any of
the source files prior to making or submitting such changes either in the
PECL developers mailing list ([email protected]) or by contacting the
current author(s) or maintainer(s) of this extension directly.
Test scripts should be included when making the submissions.
Also explain thoroughly what has been fixed/added/changed by your patch.
If your patch is easy to review and has obviously no side-effects,
it might take up to a few hours until it is committed.
Since this is a volunteer-driven effort, more complex patches will
require more patience on the part of the submitter.
================================================================================
Testing thoroughly before submissions
================================================================================
This is a fairly large library and each component is dependent on another
component either directly or indirectly.
As a consequence, any and all changes must be tested thoroughly before commiting them.
It is only polite to the users, author(s) or maintainer(s) that you do so.
================================================================================
Checklist for making submissions
================================================================================
- Did you run "make test" to check if your patch didn't break
other features?
- Did you compile PHP with --enable-debug and check the PHP and
web server error logs when you test your patch?
- Did you build PHP for multi-threaded web servers.
- Did you create test script for "make test"? (Recommended)
- Did you check your patch is unified format and it does not
contain white space changes?
- Did you read the patch again?