Skip to content

Commit e3b4328

Browse files
Remove empty validation for skeleton, fix formatting and add more tests
1 parent b9e5957 commit e3b4328

File tree

4 files changed

+162
-15
lines changed

4 files changed

+162
-15
lines changed

ext/intl/rangeformatter/rangeformatter_class.cpp

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ zend_class_entry *class_entry_IntlNumberRangeFormatter;
4242

4343
zend_object *IntlNumberRangeFormatter_object_create(zend_class_entry *ce)
4444
{
45-
IntlNumberRangeFormatter_object* intern;
45+
IntlNumberRangeFormatter_object* intern;
4646

4747
intern = reinterpret_cast<IntlNumberRangeFormatter_object*>(zend_object_alloc(sizeof(IntlNumberRangeFormatter_object), ce));
4848
zend_object_std_init(&intern->zo, ce);
@@ -84,11 +84,6 @@ U_CFUNC PHP_METHOD(IntlNumberRangeFormatter, createFromSkeleton)
8484
Z_PARAM_LONG(identityFallback)
8585
ZEND_PARSE_PARAMETERS_END();
8686

87-
if (skeleton_len == 0) {
88-
zend_argument_must_not_be_empty_error(1);
89-
RETURN_THROWS();
90-
}
91-
9287
if (locale_len == 0) {
9388
locale = (char *)intl_locale_get_default();
9489
}

0 commit comments

Comments
 (0)