Skip to content

ext/intl: fix clang build. #18535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: PHP-8.3
Choose a base branch
from
Open

Conversation

devnexen
Copy link
Member

actually, with recent icu releases, this problem arises

checking whether clang++ supports C++17 features with -std=c++17... no
checking whether clang++ supports C++17 features with +std=c++17... no
checking whether clang++ supports C++17 features with -h std=c++17... no
checking whether clang++ supports C++17 features with -std=c++1z... no
checking whether clang++ supports C++17 features with +std=c++1z... no
checking whether clang++ supports C++17 features with -h std=c++1z... no
configure: error: *** A compiler with support for C++17 language features is required.

thus, proposing to falls into LLVM libc++ instead.

actually, with recent icu releases, this problem arises

```
checking whether clang++ supports C++17 features with -std=c++17... no
checking whether clang++ supports C++17 features with +std=c++17... no
checking whether clang++ supports C++17 features with -h std=c++17... no
checking whether clang++ supports C++17 features with -std=c++1z... no
checking whether clang++ supports C++17 features with +std=c++1z... no
checking whether clang++ supports C++17 features with -h std=c++1z... no
configure: error: *** A compiler with support for C++17 language features is required.
```

thus, proposing to falls into LLVM libc++ instead.
@devnexen
Copy link
Member Author

note it happens only when ubsan is enabled.

@devnexen
Copy link
Member Author

devnexen commented May 11, 2025

so intl itself might be compiled with rtti however we compile c++ w/o exceptions nor rtti (lean binaries ?) so had to disable vptr sanitizer check.

@devnexen devnexen marked this pull request as ready for review May 11, 2025 13:18
@devnexen devnexen requested a review from TimWolla as a code owner May 11, 2025 13:18
@TimWolla TimWolla removed their request for review May 11, 2025 13:57
@devnexen devnexen requested a review from iluuu1994 May 11, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant