avoid false failure for long path #18992
Open
+1
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With very long path, socket path may be truncated before
$socketFilePrefix,
In which case, test is failing with
Socket files were not found
messageThis is a false failure, as the log contains the expected message:
[01-Jul-2025 05:38:07] WARNING: [pool fpm_pool] cannot bind to UNIX socket '/builddir/build/BUILD/php85-php-8.5.0_DEV.20250630-build/php-src-c9249e2d3aa401bda5d9a3071e86e0594807ed00/sapi/fpm/tests/socket-file-fpm-unix-socket-too-long-filename-but-starts-anyway-0000-0000-0000-0000-0000-0000-0000-0000-0000-0000-0000.sock' as path is too long (found length: 244, maximal length: 108), trying cut socket path instead '/builddir/build/BUILD/php85-php-8.5.0_DEV.20250630-build/php-src-c9249e2d3aa401bda5d9a3071e86e0594807ed00/s'
So only report about
Socket file is the same as configured
(failed test because path not truncated)Also avoid the
Warning: Undefined array key 0 in .../sapi/fpm/tests/socket-uds-too-long-filename-start.php on line 41