Skip to content

avoid false failure for long path #18992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

remicollet
Copy link
Member

With very long path, socket path may be truncated before $socketFilePrefix,

In which case, test is failing with Socket files were not found message

This is a false failure, as the log contains the expected message:

[01-Jul-2025 05:38:07] WARNING: [pool fpm_pool] cannot bind to UNIX socket '/builddir/build/BUILD/php85-php-8.5.0_DEV.20250630-build/php-src-c9249e2d3aa401bda5d9a3071e86e0594807ed00/sapi/fpm/tests/socket-file-fpm-unix-socket-too-long-filename-but-starts-anyway-0000-0000-0000-0000-0000-0000-0000-0000-0000-0000-0000.sock' as path is too long (found length: 244, maximal length: 108), trying cut socket path instead '/builddir/build/BUILD/php85-php-8.5.0_DEV.20250630-build/php-src-c9249e2d3aa401bda5d9a3071e86e0594807ed00/s'

So only report about Socket file is the same as configured (failed test because path not truncated)

Also avoid the Warning: Undefined array key 0 in .../sapi/fpm/tests/socket-uds-too-long-filename-start.php on line 41

@remicollet remicollet requested a review from bukka as a code owner July 1, 2025 03:46
@remicollet
Copy link
Member Author

Ping @JoshuaBehrens who adds this test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant