Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make core bundled extensions available (PDO, curl, intl, etc.) #133

Open
asgrim opened this issue Nov 25, 2024 · 4 comments
Open

Make core bundled extensions available (PDO, curl, intl, etc.) #133

asgrim opened this issue Nov 25, 2024 · 4 comments
Labels
enhancement New feature or request maintainer feedback needed Needs details or feedback to be added by maintainers

Comments

@asgrim
Copy link
Collaborator

asgrim commented Nov 25, 2024

Ref: https://bsky.app/profile/nizzness.bsky.social/post/3lbntufzx6c2i

Anyone know if the pie installer has plans to add things like intl, pdo, curl etc...?

Extensions in the core such as PDO, curl, intl currently aren't available in PIE. Discuss how to make them available, since a root composer.json won't really work, as it's essentially one repo with a whole bunch of extensions.

@asgrim asgrim added enhancement New feature or request maintainer feedback needed Needs details or feedback to be added by maintainers labels Nov 25, 2024
@asgrim asgrim self-assigned this Nov 25, 2024
@asgrim
Copy link
Collaborator Author

asgrim commented Nov 25, 2024

Couple of suggestions came out of PHPF discussions, I need to investigate viability further;

  • git submodules (very invasive on php-src repo, probably not ideal option...)
  • sub-tree splits (like Symfony); possible in theory, would need a repo per ext
  • may be possible internally in PIE to define a custom repository which pulls from php-src

@derickr
Copy link
Member

derickr commented Nov 27, 2024

I don't think having core extensions in PIE makes sense. Most people will install these from distributions, and if they do choose to compile their own PHP, they have all the source to compile these extensions too.

@asgrim
Copy link
Collaborator Author

asgrim commented Nov 28, 2024

I must admit, I'm now struggling to understand when you'd pie install intl for example. I'd previously thought this was being requested for things like Dockerfile images, where the PHP install is fairly barebones, but @derickr pointed out to me that usually these images use their own distro packages, (e.g. deb.sury for Ubuntu, docker-php-ext-install, Remi repo, etc.).

If anyone has a specific use-case for this please comment about it, we could still look into it, but I'm inclined to de-prioritise this at the moment if no further feedback is given. 🤔

@asgrim asgrim removed their assignment Nov 28, 2024
@macintoshplus
Copy link

On Dockerfile, you can use docker-php-ext-install to install a bundled PHP extension not already compiled.

The script docker-php-ext-enable allows to enabling of a pre-compiled and installed extension (bundled or PECL).

IMHO if PIE must know the bundled PHP extension is only to enable it if necessary for all SAPI installed.

Enable an extension is very different from various installations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintainer feedback needed Needs details or feedback to be added by maintainers
Projects
None yet
Development

No branches or pull requests

3 participants