Skip to content

Commit 0923715

Browse files
committed
[!!!TASK] Make all classes final
This library has a very large number of extension points via interfaces and abstract classes. All other classes should not be extended by users and shall theirfor be marked as final. There are a few classes left that should also be marked as final but those require some extra attention.
1 parent a16c4b6 commit 0923715

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/Config/Configuration.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
use function assert;
2121

22-
class Configuration implements ConfigurationInterface
22+
final class Configuration implements ConfigurationInterface
2323
{
2424
public function getConfigTreeBuilder(): TreeBuilder
2525
{

src/Config/XmlFileLoader.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
use function is_string;
2424
use function sprintf;
2525

26-
class XmlFileLoader extends FileLoader
26+
final class XmlFileLoader extends FileLoader
2727
{
2828
/** @return mixed[][] */
2929
public function load(mixed $resource, string|null $type = null): array

src/DependencyInjection/ApplicationExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
use function dirname;
2727
use function sprintf;
2828

29-
class ApplicationExtension extends Extension implements CompilerPassInterface
29+
final class ApplicationExtension extends Extension implements CompilerPassInterface
3030
{
3131
/** @param string[] $configs */
3232
public function load(array $configs, ContainerBuilder $container): void

tests/unit/Logger/SpyProcessorTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
use PHPUnit\Framework\TestCase;
1717

18-
class SpyProcessorTest extends TestCase
18+
final class SpyProcessorTest extends TestCase
1919
{
2020
public function testHasBeenCalledReturnsFalseByDefault(): void
2121
{

0 commit comments

Comments
 (0)