Merge pull request #21 from iMattPro/updates

Update tests

Author: iMattPro

controller/admin_controller.php

@@ -310,9 +310,7 @@ protected function trim_name(string $string, int $start, int $length): string
 		if (str_contains($string, '&') && preg_match('/&[#a-zA-Z0-9]+;/', $string))
 		{
 			$decoded = html_entity_decode($string, ENT_QUOTES | ENT_HTML5, 'UTF-8');
-
 			$trimmed = utf8_substr($decoded, $start, $length);
-
 			return htmlspecialchars($trimmed, ENT_QUOTES | ENT_HTML5, 'UTF-8');
 		}
 

tests/functional/acp_file_test.php

@@ -28,7 +28,13 @@ protected static function setup_extensions(): array
 
 	protected function setUp(): void
 	{
+		if (getenv('GITHUB_ACTIONS') !== 'true')
+		{
+			$this->markTestSkipped('This test is skipped on local test servers since they may not always work for uploading.');
+		}
+
 		parent::setUp();
+
 		$this->path = __DIR__ . '/../fixtures/';
 		$this->add_lang('posting');
 		$this->add_lang_ext('phpbb/pwakit', ['acp_pwa', 'info_acp_pwa']);